-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
param to run ALL GO rules in ontobio-parse-assocs does not run all rules #558
Comments
Oh good catch. The reason, though, this is coming in as a list is because the command line option in My thought is that since this is an artifact of the argument parsing, we should parse that there in ontobio-parse-assocs. If the incoming |
@dougli1sqrd Thanks! I just corrected it in the PR. |
Fixing ontobio-parse-assocs to run all rules; for #558
Related to #544
@dougli1sqrd Was having some trouble getting all rules to run using the new
-l all
param. I had a WB GPAD with two lines annotated to CC root but they used relationlocated_in
, which violates GO rule 61. These didn't get repaired when runningontobio-parse-assocs.py
with the-l all
param.Throwing on my debugger, I traced it to this line in
assocparser.py
:ontobio/ontobio/io/assocparser.py
Line 268 in d4fff4a
Here,
rule_set
was coming in as list["all"]
butRuleSet.ALL
is just the str"all"
:ontobio/ontobio/io/assocparser.py
Line 193 in d4fff4a
To fix, I just "listified"
RuleSet.ALL
in the conditional:@dougli1sqrd I can PR this change and you can trash it if you don't like it. Thanks!
The text was updated successfully, but these errors were encountered: