Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor to fix R CMD check issues #1

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Refactor to fix R CMD check issues #1

wants to merge 9 commits into from

Conversation

jemus42
Copy link
Member

@jemus42 jemus42 commented Nov 9, 2024

  • print method parameter naming consistency (must take args x, ...)
  • Ensure all parameters are documented
  • Ensure all external packages are properly imported
  • Ensure all imported functions are imported explicitly for easier maintenance
  • Potentially avoid dplyr dependency?
  • Fix NSE global variable usage, preferably via tidyeval idioms

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jemus42