Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Bisq API to fix scalability issues #13

Closed
wants to merge 2 commits into from

Conversation

fa2a5qj3
Copy link

Based on #6

Original version of BSQ explorer had Bisq statsnode periodically export large JSON files to disk which were read into memory arrays. This became inefficient as the blockchain grew.

This version uses a Bisq REST API as direct source of BSQ blockchain & markets data, therefore no longer duplicating the entire data set in the explorer's memory. Is a change to the Bisq portion of the mempool backend service only.

@runbtc
Copy link

runbtc commented Dec 6, 2024

I can't really help much with the code review, since I am not familiar with Typescript, but am willing to try running this.
After I finish sorting out some issues with the install scripts.

runbtc added a commit to runbtc/bisq that referenced this pull request Dec 8, 2024
Currently, it requires about 5.2G of space.
Therefore, increase it to allow for future growth.
However, hopefully this becomes irrelevant soon
with the changes in bisq-network/mempool#13.
@fa2a5qj3
Copy link
Author

Thanks for your feedback @runbtc. This main branch seems to have problems with CI, affecting this PR as well as #15 #16 #17 and #18. All this seems to have changed after #6 which is the most recent PR commit on main. (I cannot get a good answer as to why there exists both master/main when mempool upstream original only has master). I've been trying for several days to debug the CI processes which are failing in Cypress and in order to continue may need to close and re-fork. I've set-aside my patches and will attempt to re-apply when the codebase is fixed.

@fa2a5qj3 fa2a5qj3 closed this Dec 10, 2024
@runbtc
Copy link

runbtc commented Dec 10, 2024

I also do not know why there is a master and a main branch, confused me as well. Perhaps @HenrikJannsen can clarify or consolidate?

As for the CI failures, it seems even upstream mempool encounters the same failures, so I don't think is related to this fork. See https://github.com/mempool/mempool/actions/runs/12214252173/job/34074839107.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants