Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Not yet implemented" unittests #1297

Open
buhtz opened this issue Sep 16, 2022 · 0 comments
Open

"Not yet implemented" unittests #1297

buhtz opened this issue Sep 16, 2022 · 0 comments
Labels
Code Quality About code quality, refactoring, (unit) testing, linting, ... Feature requests a new feature GOOD FIRST ISSUE Used by 24pullrequests.com to suggest issues HELP-WANTED Used by 24pullrequests.com to suggest issues

Comments

@buhtz
Copy link
Member

buhtz commented Sep 16, 2022

I found some TODO-like comments and hints in the code about "Not yet implemented" unittests. I wan't to keep that notes but not in the code. Currently they produce skipped tests which is IMHO not OK. All tests should be anything else then green. I'm a bit pedantic here. 😃

Just as an example how this looks like

@unittest.skip('Not yet implemented')
def test_inhibitSuspend(self):
    pass

@unittest.skip('Not yet implemented')
def test_unInhibitSuspend(self):
    pass

So I moved that TODO's in that Issue

  • common/test/test_snapshots.py
  • common/test/test_sshtools.py
    • TestSSH.test_benchmarkCipher()
  • common/test/test_tools.py
    • TestTools.test_rsyncPrefix()
    • TestTools.test_tempFailureRetry()
    • TestTools.test_checkHomeEncrypt()
    • TestTools.test_keyringSupported()
    • TestTools.test_password()
    • TestTools.test_setPassword()
    • TestTools.test_wrapLine() (moved to logger.py) Replaced by Replace wrapLines() with Python's textwrap.wrap() #1699
    • TestTools.test_inhibitSuspend()
    • TestTools.test_unInhibitSuspend()
@emtiu emtiu added Infrastructure Feature requests a new feature Testing and removed Infrastructure labels Sep 20, 2022
@buhtz buhtz added this to the 1.3.5 / 1.4.0 milestone Mar 19, 2023
@buhtz buhtz added HELP-WANTED Used by 24pullrequests.com to suggest issues GOOD FIRST ISSUE Used by 24pullrequests.com to suggest issues labels Apr 17, 2024
@buhtz buhtz added Code Quality About code quality, refactoring, (unit) testing, linting, ... and removed Infrastructure labels Jul 30, 2024
rahulsamant37 added a commit to rahulsamant37/backintime that referenced this issue Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Code Quality About code quality, refactoring, (unit) testing, linting, ... Feature requests a new feature GOOD FIRST ISSUE Used by 24pullrequests.com to suggest issues HELP-WANTED Used by 24pullrequests.com to suggest issues
Projects
None yet
Development

No branches or pull requests

2 participants