Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests: Improve smart remove related unit tests #1821

Open
buhtz opened this issue Jul 30, 2024 · 1 comment
Open

tests: Improve smart remove related unit tests #1821

buhtz opened this issue Jul 30, 2024 · 1 comment
Assignees
@emtiu @buhtz
Labels
Code Quality About code quality, refactoring, (unit) testing, linting, ... High
Milestone
2nd release from now

Comments

@buhtz
Copy link
Member

buhtz commented Jul 30, 2024

Followup of PR #1819 and Issue #1297 .

Refactor and improve the existing unit tests about smart remove. Add new tests if appropriate.
Some tests do exist:

/common/test/test_snapshots.py::TestSnapshots.test_smartRemove*()
@buhtz buhtz self-assigned this Jul 30, 2024
@buhtz buhtz added High Code Quality About code quality, refactoring, (unit) testing, linting, ... labels Jul 30, 2024
@buhtz buhtz added this to the Upcoming release milestone Jul 30, 2024
@buhtz buhtz mentioned this issue Jul 30, 2024
Open
@emtiu emtiu self-assigned this Jul 30, 2024
@emtiu
Copy link
Member

emtiu commented Jul 30, 2024

It's my impression that the existing unittests actually assert the buggy behavior that will be fixed by #1819. But I will need to take a pen and paper and carefully make sure I understood it right :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emtiu emtiu

@buhtz buhtz

Labels
Code Quality About code quality, refactoring, (unit) testing, linting, ... High
Projects
None yet
Milestone
2nd release from now
Development

No branches or pull requests
2 participants
@emtiu @buhtz