Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1297 Issue: Updated logger.py and snapshots.py #1853

Closed

Conversation

rahulsamant37
Copy link

I have corrected the snapshot.py

and for common :: logger.py

I have improve the code by adding textwrap.wrap()

Did you run "codespell"?

@buhtz
Copy link
Member

buhtz commented Aug 27, 2024

Thank you. But please explain what you did and why.

You did not run unit Tests.

Have you read contributing.md?

And has nothing to do with #1297

@buhtz buhtz closed this Aug 27, 2024
@rahulsamant37
Copy link
Author

Sorry, if I made a mistake I'm doing it for the first time that's why I might had made some mistake. I will definitely take this as consideration for my future aspects.

@buhtz
Copy link
Member

buhtz commented Aug 28, 2024

Hello rahulsamant37,
thank you for your reply. I appreciate that.

We often have to deal with spammers, star abuse and people copy and pasting AI content as a PR. It is not easy to distinguish between a low skilled contributor and a spammer.

Next time...

Please read the CONTRIBUTING.md file carefully. This file is not only about technical details but also about the "spirit" of the project and its workflow.

The issue number (#1297) you used in your PR has nothing to do with the modifications you provide in your PR.

Describe why you made the modifications and what is your intention. It is not clear to me by just reading the "Files changed" section.

Your modifications do touch two totally separate topics (logging output & smart remove feature). Don't mix PRs like that. Keep them simple.

Best,
Christian

@rahulsamant37
Copy link
Author

Thank you for guiding me in the right direction. I understand it must be difficult for you to handle this, and I'm genuinely thankful to you for guiding me.

@rahulsamant37 rahulsamant37 deleted the rahulsamant37/issue1297 branch August 29, 2024 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants