Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Investigated smart- and auto-remove behavior #1944

Merged
merged 36 commits into from
Dec 23, 2024

Conversation

buhtz
Copy link
Member

@buhtz buhtz commented Nov 24, 2024

Related to #1945

Documentation of my research about how the smart- and auto-remove of BIT is working.

  • The docu is temporary and will result in revising the behavior including an update of the user manual and the test suite.
  • Improved doc strings.
  • Fix minor bug: smartRemoveKeepAll() now check dates and not snapshot IDs. That caused inconsistent behavior with keep-rule on day level.
  • Refactor: increment and decrement months
  • New unit tests.

Next steps after this PR is merged:

  • I will start refactoring code with the goal to add unit tests related to the auto/smart remove behavior.
  • I also have ideas how to improve the behavior, the GUI and user manual. See this mockup. I will announce this also on the mailing list and to the community.

image

@buhtz buhtz added the PR: Modifications requested Maintenance team requested modifications and waiting for their implementation label Nov 24, 2024
@buhtz buhtz self-assigned this Nov 24, 2024
@buhtz buhtz marked this pull request as draft November 24, 2024 16:54
@buhtz buhtz changed the title test: Smart remove keepFirst... doc: Investigated smart- and auto-remove behavior Dec 17, 2024
@buhtz buhtz marked this pull request as ready for review December 17, 2024 21:55
@buhtz buhtz added PR: Merge after creative-break Merge after creative-break (min. 1 week) and removed PR: Modifications requested Maintenance team requested modifications and waiting for their implementation labels Dec 17, 2024
@buhtz buhtz added this to the 1.6.0 (upcoming release) milestone Dec 17, 2024
@buhtz buhtz merged commit 62a9c6e into bit-team:dev Dec 23, 2024
1 check passed
@buhtz buhtz deleted the test/keepfirst branch December 23, 2024 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Merge after creative-break Merge after creative-break (min. 1 week)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant