forked from danielpaulus/go-ios
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: automated stopping remoted service on darwin #13
Merged
michal-przytarski
merged 6 commits into
bitbar:main
from
michal-przytarski:stop-remoted
Sep 23, 2024
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
05aa266
feat: stop remoted while running tunnel
michal-przytarski f651063
refactor: bring back commented out log
michal-przytarski 317ae7c
fix: remove hardcoded version
michal-przytarski 0dc2543
fix: make remoted management OS specific
michal-przytarski dec4f1b
feat: stop remoted for new tunnel implementation as well
michal-przytarski c765466
refactor: bring back removed log entry
michal-przytarski File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| package remoted | ||
|
|
||
| // Sends SIGSTOP to remoted process. | ||
| // Implemented only on Darwin systems, as remoted service is present only on Darwin systems | ||
| func StopRemoted() error { | ||
| return stopRemoted() | ||
| } | ||
|
|
||
| // Sends SIGCONT to remoted process. | ||
| // Implemented only on Darwin systems, as remoted service is present only on Darwin systems | ||
| func ContinueRemoted() error { | ||
| return continueRemoted() | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| //go:build darwin | ||
|
|
||
| package remoted | ||
|
|
||
| import ( | ||
| "syscall" | ||
|
|
||
| "github.com/pbar1/pkill-go" | ||
| ) | ||
|
|
||
| func stopRemoted() error { | ||
| _, err := pkill.Pkill("remoted", syscall.SIGSTOP) | ||
| return err | ||
| } | ||
|
|
||
| func continueRemoted() error { | ||
| _, err := pkill.Pkill("remoted", syscall.SIGCONT) | ||
| return err | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| //go:build !darwin | ||
|
|
||
| package remoted | ||
|
|
||
| // As remoted is present only on Darwin systems, default implementation is empty | ||
|
|
||
| func stopRemoted() error { | ||
| return nil | ||
| } | ||
|
|
||
| func continueRemoted() error { | ||
| return nil | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dont->don't