fixes a few grammatical errors #1585
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonasnick
reviewed
Aug 14, 2024
Comment on lines
82
to
84
| * limbs are in range (-2^30,2^30), this cannot overflow an int32_t. Note that the right | ||
| * shifts below are signed sign-extending shifts (see assumptions.h for tests that that is | ||
| * shifts below are signed sign-extending shifts (see assumptions.h for tests that verify that is | ||
| * indeed the behavior of the right shift operator). */ |
There was a problem hiding this comment.
Not a native speaker, but the current version seems easier to parse. Maybe "... for tests that this is indeed ...".
There was a problem hiding this comment.
NACK on this change. I think the current version on master is perfectly fine and readable, and so there's no reason to bother with it. Neither your first suggestion nor your updated suggestion seems natural to me. I feel that "that" should not be omitted here. If your grammar checker complains about a repeated word, then that's a false positive. (And I don't think Jonas' suggestion is an improvement either.)
real-or-random
added
refactor/smell
meta/development
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.