Merge pull request #344 from ZIMkaRU/feature/update-gh-actions-to-use…

…-nodejs-v20 Update gh actions to use nodejs v20
bitfinexcom · Mar 13, 2024 · 006ea5a · 006ea5a
2 parents ff7588f + e21598a
commit 006ea5a
Show file tree

Hide file tree

Showing 4 changed files with 48 additions and 16 deletions.
diff --git a/.github/workflows/build-electron-app.yml b/.github/workflows/build-electron-app.yml
@@ -214,7 +214,7 @@ jobs:
     - name: Normalize E2E test report
       run: node ./scripts/node/normalize-e2e-test-report e2e-test-report.xml
     - name: Upload Linux E2E test results
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: linux-e2e-test-results
         path: e2e-test-report.xml
@@ -246,7 +246,7 @@ jobs:
     - name: Normalize E2E test report
       run: node ./scripts/node/normalize-e2e-test-report e2e-test-report.xml
     - name: Upload Win E2E test results
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: win-e2e-test-results
         path: e2e-test-report.xml
@@ -280,7 +280,7 @@ jobs:
     - name: Normalize E2E test report
       run: node ./scripts/node/normalize-e2e-test-report e2e-test-report.xml
     - name: Upload Mac E2E test results
-      uses: actions/upload-artifact@v3
+      uses: actions/upload-artifact@v4
       with:
         name: mac-e2e-test-results
         path: e2e-test-report.xml
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -25,7 +25,7 @@ jobs:
       run: ./scripts/setup.sh -u
     - name: Run tests
       run: npm test -- -- --reporter=json --reporter-option output=test-report.json
-    - uses: actions/upload-artifact@v3
+    - uses: actions/upload-artifact@v4
       if: success() || failure()
       with:
         name: test-results

diff --git a/.github/workflows/e2e-test-report.yml b/.github/workflows/e2e-test-report.yml
@@ -18,27 +18,50 @@ jobs:
     runs-on: ubuntu-22.04
     if: ${{ github.event.workflow_run.conclusion == 'success' }}
     steps:
-    - uses: dorny/test-reporter@v1
+    - name: Download Linux E2E test results
+      uses: actions/download-artifact@v4
+      with:
+        run-id: ${{ github.event.workflow_run.id }}
+        github-token: ${{ secrets.GITHUB_TOKEN }}
+        name: linux-e2e-test-results
+        path: linux-e2e-test-results
+    - uses: dorny/test-reporter@v1.8.0
       id: linux-e2e-test-results
       with:
-        artifact: linux-e2e-test-results
         name: Linux E2E Tests
-        path: e2e-test-report.xml
+        path: linux-e2e-test-results/e2e-test-report.xml
         reporter: jest-junit
-    - uses: dorny/test-reporter@v1
+        # Workaround for error 'fatal: not a git repository' caused by a call to 'git ls-files'
+        # See: https://github.com/dorny/test-reporter/issues/169#issuecomment-1583560458
+        max-annotations: 0
+    - name: Download Win E2E test results
+      uses: actions/download-artifact@v4
+      with:
+        run-id: ${{ github.event.workflow_run.id }}
+        github-token: ${{ secrets.GITHUB_TOKEN }}
+        name: win-e2e-test-results
+        path: win-e2e-test-results
+    - uses: dorny/test-reporter@v1.8.0
       id: win-e2e-test-results
       with:
-        artifact: win-e2e-test-results
         name: Win E2E Tests
-        path: e2e-test-report.xml
+        path: win-e2e-test-results/e2e-test-report.xml
         reporter: jest-junit
-    - uses: dorny/test-reporter@v1
+        max-annotations: 0
+    - name: Download Mac E2E test results
+      uses: actions/download-artifact@v4
+      with:
+        run-id: ${{ github.event.workflow_run.id }}
+        github-token: ${{ secrets.GITHUB_TOKEN }}
+        name: mac-e2e-test-results
+        path: mac-e2e-test-results
+    - uses: dorny/test-reporter@v1.8.0
       id: mac-e2e-test-results
       with:
-        artifact: mac-e2e-test-results
         name: Mac E2E Tests
-        path: e2e-test-report.xml
+        path: mac-e2e-test-results/e2e-test-report.xml
         reporter: jest-junit
+        max-annotations: 0
     - name: E2E Test Report Summary
       run: |
         echo "### E2E Test Report page is ready! :rocket:" >> $GITHUB_STEP_SUMMARY

diff --git a/.github/workflows/test-report.yml b/.github/workflows/test-report.yml
@@ -18,13 +18,22 @@ jobs:
     runs-on: ubuntu-22.04
     if: ${{ github.event.workflow_run.conclusion == 'success' }}
     steps:
-    - uses: dorny/test-reporter@v1
+    - name: Download test results
+      uses: actions/download-artifact@v4
+      with:
+        run-id: ${{ github.event.workflow_run.id }}
+        github-token: ${{ secrets.GITHUB_TOKEN }}
+        name: test-results
+        path: test-results
+    - uses: dorny/test-reporter@v1.8.0
       id: test-results
       with:
-        artifact: test-results
         name: Mocha Tests
-        path: test-report.json
+        path: test-results/test-report.json
         reporter: mocha-json
+        # Workaround for error 'fatal: not a git repository' caused by a call to 'git ls-files'
+        # See: https://github.com/dorny/test-reporter/issues/169#issuecomment-1583560458
+        max-annotations: 0
     - name: Test Report Summary
       run: |
         echo "### Test Report page is ready! :rocket:" >> $GITHUB_STEP_SUMMARY