Merge pull request #389 from ZIMkaRU/refactoring/remove-deprecated-me…

…thods-and-fields Remove deprecated methods and fields
bitfinexcom · Aug 5, 2024 · a5b79b3 · a5b79b3
2 parents 81059c5 + 6dbb0b6
commit a5b79b3
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 131 deletions.
diff --git a/workers/api.service.report.wrk.js b/workers/api.service.report.wrk.js
@@ -73,15 +73,6 @@ class WrkReportServiceApi extends WrkApi {
   loadDIConfig (cont = container) {
     const conf = this.conf[this.group]
 
-    /**
-     * @deprecated isAddedUniqueEndingToCsvName
-     * Keep for back compatibility
-     */
-    conf.isAddedUniqueEndingToReportFileName = (
-      conf.isAddedUniqueEndingToReportFileName ??
-      conf.isAddedUniqueEndingToCsvName
-    )
-
     this.container = cont
 
     diConfig(conf, this.ctx.root)

diff --git a/workers/loc.api/generate-report-file/index.js b/workers/loc.api/generate-report-file/index.js
@@ -41,13 +41,7 @@ const _getReportFileStoreStatus = async ({
     return {
       isSaveLocaly: true,
       localReportFolderPath,
-      remoteReportUrn,
-
-      /**
-       * @deprecated fields
-       */
-      localCsvFolderPath: localReportFolderPath,
-      remoteCsvUrn: remoteReportUrn
+      remoteReportUrn
     }
   }
 

diff --git a/workers/loc.api/service.report.js b/workers/loc.api/service.report.js
@@ -678,11 +678,6 @@ class ReportService extends Api {
     }, 'getWeightedAveragesReport', args, cb)
   }
 
-  /**
-   * @deprecated
-   */
-  getMultipleCsv (...args) { return this.getMultipleFile(...args) }
-
   getMultipleFile (space, args, cb) {
     return this._responder(() => {
       return this._generateReportFile(
@@ -692,11 +687,6 @@ class ReportService extends Api {
     }, 'getMultipleFile', args, cb)
   }
 
-  /**
-   * @deprecated
-   */
-  getTradesCsv (...args) { return this.getTradesFile(...args) }
-
   getTradesFile (space, args, cb) {
     return this._responder(() => {
       return this._generateReportFile(
@@ -706,11 +696,6 @@ class ReportService extends Api {
     }, 'getTradesFile', args, cb)
   }
 
-  /**
-   * @deprecated
-   */
-  getFundingTradesCsv (...args) { return this.getFundingTradesFile(...args) }
-
   getFundingTradesFile (space, args, cb) {
     return this._responder(() => {
       return this._generateReportFile(
@@ -720,11 +705,6 @@ class ReportService extends Api {
     }, 'getFundingTradesFile', args, cb)
   }
 
-  /**
-   * @deprecated
-   */
-  getTickersHistoryCsv (...args) { return this.getTickersHistoryFile(...args) }
-
   getTickersHistoryFile (space, args, cb) {
     return this._responder(() => {
       return this._generateReportFile(
@@ -734,11 +714,6 @@ class ReportService extends Api {
     }, 'getTickersHistoryFile', args, cb)
   }
 
-  /**
-   * @deprecated
-   */
-  getWalletsCsv (...args) { return this.getWalletsFile(...args) }
-
   getWalletsFile (space, args, cb) {
     return this._responder(() => {
       return this._generateReportFile(
@@ -748,11 +723,6 @@ class ReportService extends Api {
     }, 'getWalletsFile', args, cb)
   }
 
-  /**
-   * @deprecated
-   */
-  getPositionsHistoryCsv (...args) { return this.getPositionsHistoryFile(...args) }
-
   getPositionsHistoryFile (space, args, cb) {
     return this._responder(() => {
       return this._generateReportFile(
@@ -762,11 +732,6 @@ class ReportService extends Api {
     }, 'getPositionsHistoryFile', args, cb)
   }
 
-  /**
-   * @deprecated
-   */
-  getActivePositionsCsv (...args) { return this.getActivePositionsFile(...args) }
-
   getActivePositionsFile (space, args, cb) {
     return this._responder(() => {
       return this._generateReportFile(
@@ -776,11 +741,6 @@ class ReportService extends Api {
     }, 'getActivePositionsFile', args, cb)
   }
 
-  /**
-   * @deprecated
-   */
-  getPositionsAuditCsv (...args) { return this.getPositionsAuditFile(...args) }
-
   getPositionsAuditFile (space, args, cb) {
     return this._responder(() => {
       return this._generateReportFile(
@@ -790,11 +750,6 @@ class ReportService extends Api {
     }, 'getPositionsAuditFile', args, cb)
   }
 
-  /**
-   * @deprecated
-   */
-  getPublicTradesCsv (...args) { return this.getPublicTradesFile(...args) }
-
   getPublicTradesFile (space, args, cb) {
     return this._responder(() => {
       return this._generateReportFile(
@@ -804,11 +759,6 @@ class ReportService extends Api {
     }, 'getPublicTradesFile', args, cb)
   }
 
-  /**
-   * @deprecated
-   */
-  getStatusMessagesCsv (...args) { return this.getStatusMessagesFile(...args) }
-
   getStatusMessagesFile (space, args, cb) {
     return this._responder(() => {
       return this._generateReportFile(
@@ -818,11 +768,6 @@ class ReportService extends Api {
     }, 'getStatusMessagesFile', args, cb)
   }
 
-  /**
-   * @deprecated
-   */
-  getCandlesCsv (...args) { return this.getCandlesFile(...args) }
-
   getCandlesFile (space, args, cb) {
     return this._responder(() => {
       return this._generateReportFile(
@@ -832,11 +777,6 @@ class ReportService extends Api {
     }, 'getCandlesFile', args, cb)
   }
 
-  /**
-   * @deprecated
-   */
-  getLedgersCsv (...args) { return this.getLedgersFile(...args) }
-
   getLedgersFile (space, args, cb) {
     return this._responder(() => {
       return this._generateReportFile(
@@ -846,11 +786,6 @@ class ReportService extends Api {
     }, 'getLedgersFile', args, cb)
   }
 
-  /**
-   * @deprecated
-   */
-  getPayInvoiceListCsv (...args) { return this.getPayInvoiceListFile(...args) }
-
   getPayInvoiceListFile (space, args, cb) {
     return this._responder(() => {
       return this._generateReportFile(
@@ -860,11 +795,6 @@ class ReportService extends Api {
     }, 'getPayInvoiceListFile', args, cb)
   }
 
-  /**
-   * @deprecated
-   */
-  getOrderTradesCsv (...args) { return this.getOrderTradesFile(...args) }
-
   getOrderTradesFile (space, args, cb) {
     return this._responder(() => {
       return this._generateReportFile(
@@ -874,11 +804,6 @@ class ReportService extends Api {
     }, 'getOrderTradesFile', args, cb)
   }
 
-  /**
-   * @deprecated
-   */
-  getOrdersCsv (...args) { return this.getOrdersFile(...args) }
-
   getOrdersFile (space, args, cb) {
     return this._responder(() => {
       return this._generateReportFile(
@@ -888,11 +813,6 @@ class ReportService extends Api {
     }, 'getOrdersFile', args, cb)
   }
 
-  /**
-   * @deprecated
-   */
-  getActiveOrdersCsv (...args) { return this.getActiveOrdersFile(...args) }
-
   getActiveOrdersFile (space, args, cb) {
     return this._responder(() => {
       return this._generateReportFile(
@@ -902,11 +822,6 @@ class ReportService extends Api {
     }, 'getActiveOrdersFile', args, cb)
   }
 
-  /**
-   * @deprecated
-   */
-  getMovementsCsv (...args) { return this.getMovementsFile(...args) }
-
   getMovementsFile (space, args, cb) {
     return this._responder(() => {
       return this._generateReportFile(
@@ -916,11 +831,6 @@ class ReportService extends Api {
     }, 'getMovementsFile', args, cb)
   }
 
-  /**
-   * @deprecated
-   */
-  getFundingOfferHistoryCsv (...args) { return this.getFundingOfferHistoryFile(...args) }
-
   getFundingOfferHistoryFile (space, args, cb) {
     return this._responder(() => {
       return this._generateReportFile(
@@ -930,11 +840,6 @@ class ReportService extends Api {
     }, 'getFundingOfferHistoryFile', args, cb)
   }
 
-  /**
-   * @deprecated
-   */
-  getFundingLoanHistoryCsv (...args) { return this.getFundingLoanHistoryFile(...args) }
-
   getFundingLoanHistoryFile (space, args, cb) {
     return this._responder(() => {
       return this._generateReportFile(
@@ -944,11 +849,6 @@ class ReportService extends Api {
     }, 'getFundingLoanHistoryFile', args, cb)
   }
 
-  /**
-   * @deprecated
-   */
-  getFundingCreditHistoryCsv (...args) { return this.getFundingCreditHistoryFile(...args) }
-
   getFundingCreditHistoryFile (space, args, cb) {
     return this._responder(() => {
       return this._generateReportFile(
@@ -958,11 +858,6 @@ class ReportService extends Api {
     }, 'getFundingCreditHistoryFile', args, cb)
   }
 
-  /**
-   * @deprecated
-   */
-  getLoginsCsv (...args) { return this.getLoginsFile(...args) }
-
   getLoginsFile (space, args, cb) {
     return this._responder(() => {
       return this._generateReportFile(
@@ -972,11 +867,6 @@ class ReportService extends Api {
     }, 'getLoginsFile', args, cb)
   }
 
-  /**
-   * @deprecated
-   */
-  getChangeLogsCsv (...args) { return this.getChangeLogsFile(...args) }
-
   getChangeLogsFile (space, args, cb) {
     return this._responder(() => {
       return this._generateReportFile(
@@ -986,11 +876,6 @@ class ReportService extends Api {
     }, 'getChangeLogsFile', args, cb)
   }
 
-  /**
-   * @deprecated
-   */
-  getWeightedAveragesReportCsv (...args) { return this.getWeightedAveragesReportFile(...args) }
-
   getWeightedAveragesReportFile (space, args, cb) {
     return this._responder(() => {
       return this._generateReportFile(