Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support urllib3 <2 #247

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mnowotnik
Copy link

Description

types-requests~=2.31.0.10 in setup.py causes this package to be in conflict with packages that require urllib3 < 2, even though requests package support this urllib3 version. types-requests is development only package and as such doesn't need to be installed.

Motivation and Context

Could not install vcrpy along with this package.

Type of change

  • Bug fix (non-breaking change which fixes an issue);

Checklist:

  • I've done a self-review of my code;
  • I've made sure my changes generate no warnings;
  • mypy returns no errors when run on the root package;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant