Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MKCALENDAR does not send valid calendar-timezone #1251

Open
wants to merge 1 commit into
base: main-ose
Choose a base branch
from

Conversation

ArnyminerZ
Copy link
Member

Purpose

See #1246.

Short description

Added ProdId and Version to the generated VCALENDAR.

Test request:

<?xml version='1.0' encoding='UTF-8' ?>
<CAL:mkcalendar
	xmlns="DAV:"
	xmlns:CAL="urn:ietf:params:xml:ns:caldav"
	xmlns:CARD="urn:ietf:params:xml:ns:carddav">
	<set>
		<prop>
			<resourcetype>
				<collection />
				<CAL:calendar />
			</resourcetype>
			<displayname>At Cairo</displayname>
			<CAL:calendar-description></CAL:calendar-description>
			<n0:calendar-color
				xmlns:n0="http://apple.com/ns/ical/">#0000CDFF
			</n0:calendar-color>
			<CAL:calendar-timezone-id>Africa/Cairo</CAL:calendar-timezone-id>
			<CAL:calendar-timezone>BEGIN:VCALENDAR
                 PRODID:+//IDN bitfire.at//ical4android
                 VERSION:2.0
                 BEGIN:VTIMEZONE
                 TZID:Africa/Cairo
                 LAST-MODIFIED:20240422T053450Z
                 TZURL:https://www.tzurl.org/zoneinfo/Africa/Cairo
                 X-LIC-LOCATION:Africa/Cairo
                 X-PROLEPTIC-TZNAME:LMT
                 BEGIN:STANDARD
                 TZNAME:EET
                 TZOFFSETFROM:+020509
                 TZOFFSETTO:+0200
                 DTSTART:19001001T011444
                 END:STANDARD
                 BEGIN:DAYLIGHT
                 TZNAME:EEST
                 TZOFFSETFROM:+0200
                 TZOFFSETTO:+0300
                 DTSTART:19400715T000000
                 RDATE:19410415T000000
                 RDATE:19450416T000000
                 RDATE:19570510T000000
                 RDATE:19580501T000000
                 RDATE:19820725T010000
                 RDATE:19830712T010000
                 RDATE:19890506T010000
                 RDATE:20100910T000000
                 RDATE:20140516T000000
                 RDATE:20140801T000000
                 END:DAYLIGHT
                 BEGIN:STANDARD
                 TZNAME:EET
                 TZOFFSETFROM:+0300
                 TZOFFSETTO:+0200
                 DTSTART:19401001T000000
                 RDATE:19410916T000000
                 RDATE:19421027T000000
                 RDATE:20060922T000000
                 RDATE:20070907T000000
                 RDATE:20080829T000000
                 RDATE:20090821T000000
                 RDATE:20100811T000000
                 RDATE:20101001T000000
                 RDATE:20140627T000000
                 RDATE:20140926T000000
                 END:STANDARD
                 BEGIN:DAYLIGHT
                 TZNAME:EEST
                 TZOFFSETFROM:+0200
                 TZOFFSETTO:+0300
                 DTSTART:19420401T000000
                 RRULE:FREQ=YEARLY;UNTIL=19440331T220000Z
                 END:DAYLIGHT
                 BEGIN:STANDARD
                 TZNAME:EET
                 TZOFFSETFROM:+0300
                 TZOFFSETTO:+0200
                 DTSTART:19431101T000000
                 RRULE:FREQ=YEARLY;UNTIL=19451031T210000Z
                 END:STANDARD
                 BEGIN:STANDARD
                 TZNAME:EET
                 TZOFFSETFROM:+0300
                 TZOFFSETTO:+0200
                 DTSTART:19571001T000000
                 RRULE:FREQ=YEARLY;UNTIL=19580930T210000Z
                 END:STANDARD
                 BEGIN:DAYLIGHT
                 TZNAME:EEST
                 TZOFFSETFROM:+0200
                 TZOFFSETTO:+0300
                 DTSTART:19590501T010000
                 RRULE:FREQ=YEARLY;UNTIL=19810430T230000Z
                 END:DAYLIGHT
                 BEGIN:STANDARD
                 TZNAME:EET
                 TZOFFSETFROM:+0300
                 TZOFFSETTO:+0200
                 DTSTART:19590930T030000
                 RRULE:FREQ=YEARLY;UNTIL=19650930T000000Z
                 END:STANDARD
                 BEGIN:STANDARD
                 TZNAME:EET
                 TZOFFSETFROM:+0300
                 TZOFFSETTO:+0200
                 DTSTART:19661001T030000
                 RRULE:FREQ=YEARLY;UNTIL=19941001T000000Z
                 END:STANDARD
                 BEGIN:DAYLIGHT
                 TZNAME:EEST
                 TZOFFSETFROM:+0200
                 TZOFFSETTO:+0300
                 DTSTART:19840501T010000
                 RRULE:FREQ=YEARLY;UNTIL=19880430T230000Z
                 END:DAYLIGHT
                 BEGIN:DAYLIGHT
                 TZNAME:EEST
                 TZOFFSETFROM:+0200
                 TZOFFSETTO:+0300
                 DTSTART:19900501T010000
                 RRULE:FREQ=YEARLY;UNTIL=19940430T230000Z
                 END:DAYLIGHT
                 BEGIN:DAYLIGHT
                 TZNAME:EEST
                 TZOFFSETFROM:+0200
                 TZOFFSETTO:+0300
                 DTSTART:19950428T000000
                 RRULE:FREQ=YEARLY;UNTIL=20100429T220000Z;BYMONTH=4;BYDAY=-1FR
                 END:DAYLIGHT
                 BEGIN:STANDARD
                 TZNAME:EET
                 TZOFFSETFROM:+0300
                 TZOFFSETTO:+0200
                 DTSTART:19950929T000000
                 RRULE:FREQ=YEARLY;UNTIL=20050929T210000Z;BYYEARDAY=-92,-93,-94,-95,-96,-97,-98;BYDAY=FR
                 END:STANDARD
                 BEGIN:DAYLIGHT
                 TZNAME:EEST
                 TZOFFSETFROM:+0200
                 TZOFFSETTO:+0300
                 DTSTART:20230428T000000
                 RRULE:FREQ=YEARLY;BYMONTH=4;BYDAY=-1FR
                 END:DAYLIGHT
                 BEGIN:STANDARD
                 TZNAME:EET
                 TZOFFSETFROM:+0300
                 TZOFFSETTO:+0200
                 DTSTART:20231027T000000
                 RRULE:FREQ=YEARLY;BYYEARDAY=-61,-62,-63,-64,-65,-66,-67;BYDAY=FR
                 END:STANDARD
                 END:VTIMEZONE
                 END:VCALENDAR
                 </CAL:calendar-timezone>
		</prop>
	</set>
</CAL:mkcalendar>

Checklist

  • The PR has a proper title, description and label.
  • I have self-reviewed the PR.
  • I have added documentation to complex functions and functions that can be used by other modules.
  • I have added reasonable tests or consciously decided to not add tests.

Signed-off-by: Arnau Mora <arnyminerz@proton.me>
@ArnyminerZ ArnyminerZ added the bug Something isn't working label Jan 20, 2025
@ArnyminerZ ArnyminerZ self-assigned this Jan 20, 2025
@ArnyminerZ ArnyminerZ linked an issue Jan 20, 2025 that may be closed by this pull request
2 tasks
@ArnyminerZ ArnyminerZ requested a review from rfc2822 January 20, 2025 11:28
@ArnyminerZ ArnyminerZ marked this pull request as ready for review January 20, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MKCALENDAR does not send valid calendar-timezone
1 participant