Merge pull request #40 from bitfocus/bug/noconfig

Fix crash on new module with empty config
bitfocus · Nov 5, 2024 · 1b162fe · 1b162fe
2 parents af714b0 + 75ad6da
commit 1b162fe
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 4 deletions.
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
 	"name": "tplink-kasasmartplug",
-	"version": "2.2.2",
+	"version": "2.2.3",
 	"main": "src/index.js",
 	"type": "module",
 	"scripts": {

diff --git a/src/config.js b/src/config.js
@@ -27,12 +27,13 @@ export function getConfigFields() {
 		width: 12,
 	})
 
-	let ch = []
+	let ch = [{id: 'none', label: 'No Kasa Plugs Located'}]
 	let def = 'none'
 	if (Object.keys(this.FOUND_PLUGS || {}).length == 0) {
-		ch = [{ id: 'none', label: 'No Kasa Plugs located' }]
+    if (this.config) {
 		this.config.plugId = 'none'
 		this.saveConfig(this.config)
+    }
 	} else {
 		ch = [{ id: 'none', label: 'No plug selected' }]
 		const plugs = this.FOUND_PLUGS

diff --git a/src/index.js b/src/index.js
@@ -112,7 +112,7 @@ class kasaplugInstance extends InstanceBase {
 		if (config.host != '') {
 			this.updateStatus(InstanceStatus.Connecting)
 		} else {
-			this.updateStatus(InstanceStatus.BadConfig, 'IP address not set')
+			this.updateStatus(InstanceStatus.ConnectionFailure, 'IP address not set')
 			this.FOUND_PLUGS = []
 			resave = true
 		}