From 36d346d845994bf9b572337f5bd6f9daa4b12cbd Mon Sep 17 00:00:00 2001 From: Paul-Lukas Kovacic Date: Tue, 1 Oct 2024 13:40:56 +0200 Subject: [PATCH 1/5] feat: Add new SSAI attributes --- src/types/queryAdAttributes.ts | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/src/types/queryAdAttributes.ts b/src/types/queryAdAttributes.ts index 5bfbd76..24a981b 100644 --- a/src/types/queryAdAttributes.ts +++ b/src/types/queryAdAttributes.ts @@ -2,6 +2,7 @@ import { SelectableValue } from '@grafana/data'; const QUERY_AD_ATTRIBUTES = [ 'ADVERTISER_NAME', + 'AD_ABANDONMENT_RATE', 'AD_CLICKTHROUGH_URL', 'AD_DESCRIPTION', 'AD_DURATION', @@ -9,6 +10,7 @@ const QUERY_AD_ATTRIBUTES = [ 'AD_ID', 'AD_ID_PLAYER', 'AD_IMPRESSION_ID', + 'AD_INDEX', 'AD_IS_PERSISTENT', 'AD_MODULE', 'AD_OFFSET', @@ -27,6 +29,7 @@ const QUERY_AD_ATTRIBUTES = [ 'AD_TAG_TYPE', 'AD_TAG_URL', 'AD_TITLE', + 'AD_TYPE', 'AD_WRAPPER_ADS_COUNT', 'ANALYTICS_VERSION', 'APIORG_ID', @@ -49,6 +52,7 @@ const QUERY_AD_ATTRIBUTES = [ 'CLOSE_PERCENTAGE', 'CLOSE_POSITION', 'COMPLETED', + 'COMPLETED_FAILED_BEACON_URL', 'COUNTRY', 'CREATIVE_AD_ID', 'CREATIVE_ID', @@ -102,6 +106,7 @@ const QUERY_AD_ATTRIBUTES = [ 'MEDIA_SERVER', 'MEDIA_URL', 'MIDPOINT', + 'MIDPOINT_FAILED_BEACON_URL', 'MINUTE', 'MIN_SUGGESTED_DURATION', 'MONTH', @@ -120,7 +125,9 @@ const QUERY_AD_ATTRIBUTES = [ 'PLAYER_VERSION', 'PLAY_PERCENTAGE', 'QUARTILE_1', + 'QUARTILE1_FAILED_BEACON_URL', 'QUARTILE_3', + 'QUARTILE3_FAILED_BEACON_URL', 'REGION', 'SCREEN_HEIGHT', 'SCREEN_WIDTH', From 9e151a69dad370b5ddf7128fa598ce7e13ed934c Mon Sep 17 00:00:00 2001 From: Paul-Lukas Kovacic Date: Tue, 1 Oct 2024 14:00:42 +0200 Subject: [PATCH 2/5] feat: Add new SSAI attributes --- src/types/queryAttributes.ts | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/src/types/queryAttributes.ts b/src/types/queryAttributes.ts index af42b6a..218c005 100644 --- a/src/types/queryAttributes.ts +++ b/src/types/queryAttributes.ts @@ -2,6 +2,10 @@ import { SelectableValue } from '@grafana/data'; const QUERY_ATTRIBUTES = [ 'AD', + 'AD_ID', + 'AD_INDEX', + 'AD_POSITION', + 'AD_SYSTEM', 'ANALYTICS_VERSION', 'AUDIO_BITRATE', 'AUDIO_CODEC', From be073ec32964a07d86c44dcec6057b6f76f71cc4 Mon Sep 17 00:00:00 2001 From: Paul-Lukas Kovacic Date: Tue, 1 Oct 2024 14:41:11 +0200 Subject: [PATCH 3/5] feat: convert AD_INDEX and AD_TYPE to correct datatype --- src/utils/filterUtils.ts | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/utils/filterUtils.ts b/src/utils/filterUtils.ts index 43fe729..de4421e 100644 --- a/src/utils/filterUtils.ts +++ b/src/utils/filterUtils.ts @@ -63,6 +63,8 @@ const convertFilterForAds = (rawValue: string, filterAttribute: QueryAdAttribute case 'IS_LINEAR': return rawValue === 'true'; + case 'AD_INDEX': + case 'AD_TYPE': case 'AD_STARTUP_TIME': case 'AD_WRAPPER_ADS_COUNT': case 'AUDIO_BITRATE': @@ -114,6 +116,7 @@ const convertFilter = (rawValue: string, filterAttribute: QueryAttribute) => { return rawValue === 'true'; case 'AUDIO_BITRATE': + case 'AD_INDEX': case 'BUFFERED': case 'CLIENT_TIME': case 'DOWNLOAD_SPEED': From 33fa67419a86e63e2f98332b0d5e9ed4e116fb05 Mon Sep 17 00:00:00 2001 From: Paul-Lukas Kovacic Date: Tue, 1 Oct 2024 14:51:00 +0200 Subject: [PATCH 4/5] Updated CHANGELOG.md --- CHANGELOG.md | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index aefb5db..a7de05c 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,10 @@ ## Development +### Added + +- SSAI attributes + ## 1.2.0 ### Fix From a69a07425ce400acef756648b22821dfbf925973 Mon Sep 17 00:00:00 2001 From: Paul-Lukas Kovacic Date: Tue, 1 Oct 2024 15:24:52 +0200 Subject: [PATCH 5/5] feat: Made AD_TYPE filter nullable --- src/utils/filterUtils.ts | 1 + 1 file changed, 1 insertion(+) diff --git a/src/utils/filterUtils.ts b/src/utils/filterUtils.ts index de4421e..c9cc56b 100644 --- a/src/utils/filterUtils.ts +++ b/src/utils/filterUtils.ts @@ -6,6 +6,7 @@ import { QueryAttribute } from '../types/queryAttributes'; const isNullFilter = (filterAttribute: QueryAttribute | QueryAdAttribute): boolean => { switch (filterAttribute) { + case 'AD_TYPE': case 'CDN_PROVIDER': case 'CUSTOM_DATA_1': case 'CUSTOM_DATA_2':