-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/Stack trace #53
base: develop
Are you sure you want to change the base?
Feat/Stack trace #53
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, but let's wait for the Conviva validation results. Some changes for the Changelog file though.
Would you mind signing our Contributor License Agreement please?
I've signed that. Let's wait for the validation. |
The PR validation was successfully completed by team conviva. Error reporting for both Video Start Failure and Video Playback Failure is functioning as expected, displaying the correct error codes and messages. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Error reporting is fine, working as expected
This commit addresses XYEYE- 12 (Android stack trace feature) and is based on the latest Conviva SDK.
While waiting for the Conviva validation report, we tried to retrieve the stack trace of
Player's/Source's Error
events and report it to TouchStone. It was tested with a sample stream with ads. In case of errors, a custom event will be fired containing stack trace information, which can be observed in TouchStone.In the ideal case (no issues from the validation report), this PR will also complete XYEYE- 15 (Android update).