Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/Stack trace #53

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Conversation

Wkkkkk
Copy link

@Wkkkkk Wkkkkk commented Aug 18, 2023

This commit addresses XYEYE- 12 (Android stack trace feature) and is based on the latest Conviva SDK.

While waiting for the Conviva validation report, we tried to retrieve the stack trace of Player's/Source's Error events and report it to TouchStone. It was tested with a sample stream with ads. In case of errors, a custom event will be fired containing stack trace information, which can be observed in TouchStone.

In the ideal case (no issues from the validation report), this PR will also complete XYEYE- 15 (Android update).

@CLAassistant
Copy link

CLAassistant commented Aug 18, 2023

CLA assistant check
All committers have signed the CLA.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Member

@dweinber dweinber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, but let's wait for the Conviva validation results. Some changes for the Changelog file though.

Would you mind signing our Contributor License Agreement please?

CHANGELOG.md Show resolved Hide resolved
CHANGELOG.md Show resolved Hide resolved
@Wkkkkk
Copy link
Author

Wkkkkk commented Aug 21, 2023

I've signed that. Let's wait for the validation.

@dweinber
Copy link
Member

dweinber commented Aug 21, 2023

Something looks a bit fishy here:
image

Anyway, that's something for us to figure out, no need to worry for you. As at least one of the two messages shows up as signed, that should be fine - thanks! 👍

Cool, looking forward to Conviva validation feedback, let's hope the best 🤞

@kannan-sivam
Copy link

The PR validation was successfully completed by team conviva. Error reporting for both Video Start Failure and Video Playback Failure is functioning as expected, displaying the correct error codes and messages.

Copy link

@kannan-sivam kannan-sivam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Error reporting is fine, working as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants