Introduce onPictureInPictureModeChanged to FlutterPlayerView (PiP #2) #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zigavehovec
changed the base branch from
main
to
PFL-83/add-lifecycle-handling
…ation-change-handling # Conflicts: # android/src/main/kotlin/com/bitmovin/player/flutter/FlutterPlayerView.kt
zigavehovec
changed the title
zigavehovec
changed the title
zigavehovec
requested review from
krocard,
strangesource and
testcenter
and removed request for
krocard
testcenter
approved these changes
Dec 19, 2023
| isInPictureInPictureMode: Boolean, | ||
| newConfig: Configuration, | ||
| ) { | ||
| // TODO: Handle picture in picture mode changed |
There was a problem hiding this comment.
I guess this TODO will be part of a future PR, right?
strangesource
approved these changes
Dec 19, 2023
…ation-change-handling # Conflicts: # android/src/main/kotlin/com/bitmovin/player/flutter/FlutterPlayerView.kt
|
I found an issue with the component callbacks on Android 10 and had to change the implementation. Please review again. |
| @@ -111,6 +119,28 @@ class FlutterPlayerView( | |||
| sink = null | |||
| } | |||
|
|
|||
| private fun PlayerView.setOnPictureInPictureModeChanged(callback: (Boolean, Configuration) -> Unit) { | |||
There was a problem hiding this comment.
Suggested change
| private fun PlayerView.setOnPictureInPictureModeChanged(callback: (Boolean, Configuration) -> Unit) { | |
| private fun PlayerView.setOnPictureInPictureModeChangedCallback(callback: (Boolean, Configuration) -> Unit) { |
Where will this function be called from? I can't see any usage yet.
There was a problem hiding this comment.
It will be called from the init block where we check out the playerView arguments. Right after the fullscreen handler initialization.
android/src/main/kotlin/com/bitmovin/player/flutter/FlutterPlayerView.kt
Outdated
Show resolved
Hide resolved
testcenter
approved these changes
Dec 21, 2023
…yerView.kt Co-authored-by: Lukas Knoch-Girstmair <strangesource@users.noreply.github.com>
…yerView.kt Co-authored-by: Lukas Knoch-Girstmair <strangesource@users.noreply.github.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is currently no way to get notified from the OS that PiP mode has been activated.
Listening to PiP changes usually happens by overriding onPictureInPictureModeChanged in the Activity. This is not really doable in a SDK context since the library consumer actually controls the activity.
To work around this issue, this PR introduces aComponentCallbacksinstance registered to an instance of the Activity, this way we can get notified about configuration changes.Edit: unfortunately, component callbacks don't work for some Android versions (tested on Android 10 with FlutterFragmentActivity). My suspicion is that it's an issue in Flutter's activity - since one can also observe activity getting a red color overlay.
The configuration change listening is now done by overriding view's
onConfigurationChanged. Since Flutter's PlatformView isn't actually an Android View we have to add a blank view to the PlayerView in order to be able to override the mentioned function.In combination with activity.isInPictureInPictureMode we can imitate Activity's onPictureInPictureModeChanged.
This PR is prework for PiP implementation.
Changes
onPictureInPictureModeChangedcallbackTests
Checklist (for PR submitters and reviewers)
CHANGELOG.mdentry for new/changed features, bug fixes or important code changes