Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add John to Contributors list and update on readme - maybe #32

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add John to Contributors list and update on readme - maybe #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Contributors.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@
- [Daniel Kim 🇰🇷](https://twitter.com/journeyer_)
- [Shayan Riyaz :pakistan:](https://www.linkedin.com/in/shayan-riyaz/)
- [Bryan Wong]
- [John Poulos]
4 changes: 4 additions & 0 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,10 @@ git checkout -b add-daniel-kim

Now open `Contributors.md` file in a text editor, add your name to it. Don't add it at the beginning or end of the file. Put it anywhere in between. Now, save the file.

*************For Consideration****************
Might want to consider revising the instruction that prompts new contributors to add their names to the middle of the list. It caused my addition to have a merge conflict. Might be better to advise them to add their names to the end of the list instead?
**********************************************

<img align="right" width="450" src="assets/git-status.png" alt="git status" />

If you go to the project directory and execute the command `git status`, you'll see there are changes.
Expand Down