added validation test (#664)

* added validation test

* fixed test

* fixed wrong test dir path

* fixed comment

* added comments and updated format version

* update comments

* updated with PR change requests

_tests/integration/test_deploy_structure_check.yml

@@ -0,0 +1,12 @@
+format_version: 7
+default_step_lib_source: https://github.com/bitrise-io/bitrise-steplib.git
+
+workflows:
+  test-deploy-dir-structure-check:
+    description: |
+      Check if test result dir is under test deploy dir
+    steps:
+    - script:
+        inputs:
+        - content: |-
+            if [[ "$(dirname $BITRISE_TEST_RESULT_DIR)" != "$BITRISE_TEST_DEPLOY_DIR" ]]; then exit 1; fi

_tests/integration/test_deploy_structure_check_test.go

@@ -0,0 +1,20 @@
+package integration
+
+import (
+	"testing"
+
+	"github.com/bitrise-io/go-utils/command"
+)
+
+func Test_DeployDirStructure(t *testing.T) {
+	t.Log("check test deploy dir structure")
+	{
+		configPth := "test_deploy_structure_check.yml"
+
+		cmd := command.New(binPath(), "run", "test-deploy-dir-structure-check", "--config", configPth)
+		out, err := cmd.RunAndReturnTrimmedCombinedOutput()
+		if err != nil {
+			t.Fatal(err, out)
+		}
+	}
+}

cli/run_util.go

@@ -887,15 +887,15 @@ func activateAndRunSteps(
 			})
 
 			// ensure a new testDirPath and if created successfuly then attach it to the step process by and env
-			testDirPath, err := ioutil.TempDir(os.Getenv(configs.BitriseTestResultDirEnvKey), "test_result")
+			testDirPath, err := ioutil.TempDir(os.Getenv(configs.BitriseTestDeployDirEnvKey), "test_result")
 			if err != nil {
 				log.Errorf("Failed to create test result dir, error: %s", err)
 			}
 
 			if testDirPath != "" {
 				// managed to create the test dir, set the env for it for the next step run
 				additionalEnvironments = append(additionalEnvironments, envmanModels.EnvironmentItemModel{
-					configs.BitriseTestResultDirEnvKey: testDirPath,
+					configs.BitrisePerStepTestResultDirEnvKey: testDirPath,
 				})
 			}
 

configs/paths.go

@@ -34,10 +34,10 @@ const (
 	BitriseSourceDirEnvKey = "BITRISE_SOURCE_DIR"
 	// BitriseDeployDirEnvKey ...
 	BitriseDeployDirEnvKey = "BITRISE_DEPLOY_DIR"
-	// BitriseTestDeployDirEnvKey ...
+	// BitriseTestDeployDirEnvKey is the root directory of test reports
 	BitriseTestDeployDirEnvKey = "BITRISE_TEST_DEPLOY_DIR"
-	// BitriseTestResultDirEnvKey ...
-	BitriseTestResultDirEnvKey = "BITRISE_TEST_RESULT_DIR"
+	// BitrisePerStepTestResultDirEnvKey is a unique subdirectory in BITRISE_TEST_DEPLOY_DIR for each step run, steps should place test reports and attachments into this directory
+	BitrisePerStepTestResultDirEnvKey = "BITRISE_TEST_RESULT_DIR"
 	// BitriseCacheDirEnvKey ...
 	BitriseCacheDirEnvKey = "BITRISE_CACHE_DIR"
 	// BitriseTmpDirEnvKey ...