-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Polish BSIP40 with latest change requests #2203
base: release
Are you sure you want to change the base?
Commits on Jun 17, 2020
-
[BSIP40] Add external serializations
See https://github.com/bitshares/bitshares-core/pull/ 2093#discussion_r399386266
Configuration menu - View commit details
-
Copy full SHA for bc5c34b - Browse repository at this point
Copy the full SHA bc5c34bView commit details -
[BSIP40] Add field support check
See https://github.com/bitshares/bitshares-core/pull/ 2093#discussion_r401052309 A compile error is now thrown if any operation field type is unsupported in use in any predicate with any argument type. See https://github.com/bitshares/bitshares-core/pull/ 2093#discussion_r400286103 Unsigned_int is now supported as an integral type
Configuration menu - View commit details
-
Copy full SHA for 3cd47d1 - Browse repository at this point
Copy the full SHA 3cd47d1View commit details -
[BSIP40] Generate list_#.cpp files
See bitshares#2093 (comment) Add a cmake template file for the list_#.cpp files and autogenerate them from the template rather than having 12 almost identical copies of a file
Configuration menu - View commit details
-
Copy full SHA for 738ac6f - Browse repository at this point
Copy the full SHA 738ac6fView commit details -
See https://github.com/bitshares/bitshares-core/pull/ 2093#discussion_r400317820
Configuration menu - View commit details
-
Copy full SHA for 71de24b - Browse repository at this point
Copy the full SHA 71de24bView commit details -
[BSIP40] Adjust argument types
See: https://github.com/bitshares/bitshares-core/pull/ 2093#discussion_r401581235 https://github.com/bitshares/bitshares-core/pull/ 2093#discussion_r401581502 https://github.com/bitshares/bitshares-core/pull/ 2093#discussion_r401582839 https://github.com/bitshares/bitshares-core/pull/ 2093#discussion_r401583091 https://github.com/bitshares/bitshares-core/pull/ 2093#discussion_r401588755
Configuration menu - View commit details
-
Copy full SHA for b957a22 - Browse repository at this point
Copy the full SHA b957a22View commit details -
[BSIP40] Remove support for unsupported operations
See: https://github.com/bitshares/bitshares-core/pull/ 2093#discussion_r401599873
Configuration menu - View commit details
-
Copy full SHA for 56d7ef6 - Browse repository at this point
Copy the full SHA 56d7ef6View commit details
Commits on Jun 18, 2020
-
[BSIP40] Add some hash argument types
See: https://github.com/bitshares/bitshares-core/pull/ 2093#discussion_r401604111 I can still get away with reordering the list like this because it's never been released yet.
Configuration menu - View commit details
-
Copy full SHA for 7c66d15 - Browse repository at this point
Copy the full SHA 7c66d15View commit details -
[BSIP40] Stringified and variant comparisons
Now allows ==, !=, <, <=, >, >= for stringish types (including hashes and vector<char>s), container size vs int, and static_variant.which() values vs int. vector<char> is no longer considered a container, but is considered stringish See: https://github.com/bitshares/bitshares-core/pull/ 2093#discussion_r401604111 https://github.com/bitshares/bitshares-core/pull/ 2093#discussion_r401635775 https://github.com/bitshares/bitshares-core/pull/ 2093#discussion_r401642590
Configuration menu - View commit details
-
Copy full SHA for 4e81e2b - Browse repository at this point
Copy the full SHA 4e81e2bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 0ac5399 - Browse repository at this point
Copy the full SHA 0ac5399View commit details -
Add support for innteger comparisons against a stringish that is not a container, necessary because vector<char> is no longer a container but only stringish.
Configuration menu - View commit details
-
Copy full SHA for c4acdf4 - Browse repository at this point
Copy the full SHA c4acdf4View commit details