Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Polish BSIP40 with latest change requests #2203

Open
wants to merge 10 commits into
base: release
Choose a base branch
from

Commits on Jun 17, 2020

  1. Configuration menu
    Copy the full SHA
    bc5c34b View commit details
    Browse the repository at this point in the history
  2. [BSIP40] Add field support check

    See https://github.com/bitshares/bitshares-core/pull/
    2093#discussion_r401052309
    
    A compile error is now thrown if any operation field type is unsupported
    in use in any predicate with any argument type.
    
    See https://github.com/bitshares/bitshares-core/pull/
    2093#discussion_r400286103
    
    Unsigned_int is now supported as an integral type
    nathanielhourt committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    3cd47d1 View commit details
    Browse the repository at this point in the history
  3. [BSIP40] Generate list_#.cpp files

    See bitshares#2093 (comment)
    
    Add a cmake template file for the list_#.cpp files and autogenerate them
    from the template rather than having 12 almost identical copies of a file
    nathanielhourt committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    738ac6f View commit details
    Browse the repository at this point in the history
  4. [BSIP40] Replace > with <

    nathanielhourt committed Jun 17, 2020
    Configuration menu
    Copy the full SHA
    71de24b View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    b957a22 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    56d7ef6 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2020

  1. [BSIP40] Add some hash argument types

    See: https://github.com/bitshares/bitshares-core/pull/
    2093#discussion_r401604111
    
    I can still get away with reordering the list like this because it's
    never been released yet.
    nathanielhourt committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    7c66d15 View commit details
    Browse the repository at this point in the history
  2. [BSIP40] Stringified and variant comparisons

    Now allows ==, !=, <, <=, >, >= for stringish types (including hashes
    and vector<char>s), container size vs int, and static_variant.which()
    values vs int.
    
    vector<char> is no longer considered a container, but is considered
    stringish
    
    See:
    https://github.com/bitshares/bitshares-core/pull/
    2093#discussion_r401604111
    https://github.com/bitshares/bitshares-core/pull/
    2093#discussion_r401635775
    https://github.com/bitshares/bitshares-core/pull/
    2093#discussion_r401642590
    nathanielhourt committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    4e81e2b View commit details
    Browse the repository at this point in the history
  3. Bump fc

    nathanielhourt committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    0ac5399 View commit details
    Browse the repository at this point in the history
  4. [BSIP40] Fix test

    Add support for innteger comparisons against a stringish that is not a
    container, necessary because vector<char> is no longer a container but
    only stringish.
    nathanielhourt committed Jun 18, 2020
    Configuration menu
    Copy the full SHA
    c4acdf4 View commit details
    Browse the repository at this point in the history