Add FINC/FDEC HITL-test #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martijnbastiaan
force-pushed
the
fincfdectest
branch
3 times, most recently
from
f4c194a
to
b31a13b
Compare
hiddemoll
force-pushed
the
fincfdectest
branch
2 times, most recently
from
d1fbffd
to
d6d5a5f
Compare
hiddemoll
reviewed
Jul 4, 2023
|
Thanks for the review @hiddemoll, agreed on all points. I'll wait for #332 to shape up before removing all the hacks. |
martijnbastiaan
force-pushed
the
fincfdectest
branch
5 times, most recently
from
12bb11c
to
693e865
Compare
martijnbastiaan
force-pushed
the
add-drc
branch
2 times, most recently
from
ecfd2fa
to
8002383
Compare
martijnbastiaan
force-pushed
the
fincfdectest
branch
from
693e865
to
1b6a5ef
Compare
martijnbastiaan
force-pushed
the
fincfdectest
branch
9 times, most recently
from
75ba625
to
39dc4fa
Compare
4 tasks
lmbollen
requested changes
Jul 13, 2023
martijnbastiaan
force-pushed
the
fincfdectest
branch
from
39dc4fa
to
1271df5
Compare
martijnbastiaan
force-pushed
the
fincfdectest
branch
from
1271df5
to
79faeea
Compare
martijnbastiaan
force-pushed
the
fincfdectest
branch
2 times, most recently
from
0c11cd3
to
fb51d59
Compare
lmbollen
reviewed
Jul 19, 2023
martijnbastiaan
force-pushed
the
fincfdectest
branch
from
fb51d59
to
e62f669
Compare
lmbollen
approved these changes
Jul 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although we've seen the clock demo (milestone 3) working, we'd like a test suite made up of all separate components making up the demo. This means that in the future - especially when disassembling and reassembling the demo rack - we'll quickly get pointed to the components that are wrongly connected / failing.
This PR adds a test that: