Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Circuit for Bittide Nodes #627

Merged
merged 2 commits into from
Oct 17, 2024
Merged

Use Circuit for Bittide Nodes #627

merged 2 commits into from
Oct 17, 2024

Conversation

lmbollen
Copy link
Contributor

First effort to use Circuit in Bittide nodes

Copy link
Contributor

@hydrolarus hydrolarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, could use a rebase since the Link stuff was removed and some comments should be updated.

Comment on lines 26 to 30
import Control.Arrow ((&&&))

instance IdleCircuit (Jtag dom) where
idleFwd _ = pure $ JtagIn low low low
idleBwd _ = pure $ JtagOut low low
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should probably go into clash-vexriscv

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bittide/src/Bittide/Node.hs Outdated Show resolved Hide resolved
bittide/src/Bittide/Switch.hs Outdated Show resolved Hide resolved
bittide/src/Bittide/Node.hs Outdated Show resolved Hide resolved
@lmbollen lmbollen force-pushed the lucas/circuitify-node branch 4 times, most recently from 01c4255 to c7205ef Compare September 24, 2024 08:21
@lmbollen lmbollen marked this pull request as ready for review October 11, 2024 12:41
Copy link
Contributor

@hydrolarus hydrolarus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good! Just a question about PR order stuff

bittide/src/Bittide/Node.hs Show resolved Hide resolved
@lmbollen lmbollen merged commit 6053687 into staging Oct 17, 2024
63 of 80 checks passed
@lmbollen lmbollen deleted the lucas/circuitify-node branch October 17, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants