-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Circuit
for Bittide Nodes
#627
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good, could use a rebase since the Link stuff was removed and some comments should be updated.
bittide/src/Bittide/Node.hs
Outdated
import Control.Arrow ((&&&)) | ||
|
||
instance IdleCircuit (Jtag dom) where | ||
idleFwd _ = pure $ JtagIn low low low | ||
idleBwd _ = pure $ JtagOut low low |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably go into clash-vexriscv
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
01c4255
to
c7205ef
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good! Just a question about PR order stuff
9ba4df4
to
694e032
Compare
694e032
to
cb105dc
Compare
cb105dc
to
694e032
Compare
First effort to use
Circuit
in Bittide nodes