Skip to content

Commit

Permalink
Fixed some effect param values
Browse files Browse the repository at this point in the history
I messed up some parameter values for the Multi Delay, Reverb Delay, and Autopan.  Fixed all those.
  • Loading branch information
bkshepherd committed Dec 29, 2024
1 parent 961e82c commit d815e1a
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion Software/GuitarPedal/Effect-Modules/autopan_module.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ void AutoPanModule::ProcessMono(float in) {
m_freqOsc.SetFreq(m_freqOscFreqMin + (GetParameterAsFloat(2) * m_freqOscFreqMax));
float mod = 0.5f + m_freqOsc.Process();

if (GetParameterRaw(2) == 0) {
if (GetParameterAsFloat(2) <= 0.01f) {
mod = 0.5f;
m_pan = mod;
}
Expand Down
4 changes: 2 additions & 2 deletions Software/GuitarPedal/Effect-Modules/multi_delay_module.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ static const ParameterMetaData s_metaData[s_paramCount] = {{
knobMapping : 0,
midiCCMapping : 20,
minValue : 0,
maxValue : 100
maxValue : 1
},
{
name : "Delay L ms",
Expand Down Expand Up @@ -75,7 +75,7 @@ static const ParameterMetaData s_metaData[s_paramCount] = {{
knobMapping : 3,
midiCCMapping : 31,
minValue : 0,
maxValue : 100,
maxValue : 1,
},
{
name : "Tap Mode",
Expand Down
4 changes: 2 additions & 2 deletions Software/GuitarPedal/Effect-Modules/reverb_delay_module.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -406,7 +406,7 @@ void ReverbDelayModule::ProcessMono(float in) {
// Calculate any delay spread
delaySpread.delayTarget = m_delaySpreadMin + (m_delaySpreadMax - m_delaySpreadMin) * GetParameterAsFloat(11);
float delSpread_out = delaySpread.Process(delRight_out);
if (GetParameterRaw(11) > 0 && !GetParameterAsBool(12)) {
if (GetParameterAsFloat(11) > 0.0f && !GetParameterAsBool(12)) {
delRight_out = delSpread_out;
}

Expand Down Expand Up @@ -494,7 +494,7 @@ void ReverbDelayModule::ProcessStereo(float inL, float inR) {
// Calculate any delay spread
delaySpread.delayTarget = m_delaySpreadMin + (m_delaySpreadMax - m_delaySpreadMin) * GetParameterAsFloat(11);
float delSpread_out = delaySpread.Process(delRight_out);
if (GetParameterRaw(11) > 0 && !GetParameterAsBool(12)) { // If spread > 0 and dual delay isn't on
if (GetParameterAsFloat(11) > 0.0f && !GetParameterAsBool(12)) { // If spread > 0 and dual delay isn't on
delRight_out = delSpread_out;
}

Expand Down

0 comments on commit d815e1a

Please sign in to comment.