From d815e1ac647fc6b7f67ed973fb8e95c0d49779b3 Mon Sep 17 00:00:00 2001 From: Keith Shepherd Date: Sun, 29 Dec 2024 13:51:32 -0500 Subject: [PATCH] Fixed some effect param values I messed up some parameter values for the Multi Delay, Reverb Delay, and Autopan. Fixed all those. --- Software/GuitarPedal/Effect-Modules/autopan_module.cpp | 2 +- Software/GuitarPedal/Effect-Modules/multi_delay_module.cpp | 4 ++-- Software/GuitarPedal/Effect-Modules/reverb_delay_module.cpp | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/Software/GuitarPedal/Effect-Modules/autopan_module.cpp b/Software/GuitarPedal/Effect-Modules/autopan_module.cpp index fe77522..9f65c30 100644 --- a/Software/GuitarPedal/Effect-Modules/autopan_module.cpp +++ b/Software/GuitarPedal/Effect-Modules/autopan_module.cpp @@ -65,7 +65,7 @@ void AutoPanModule::ProcessMono(float in) { m_freqOsc.SetFreq(m_freqOscFreqMin + (GetParameterAsFloat(2) * m_freqOscFreqMax)); float mod = 0.5f + m_freqOsc.Process(); - if (GetParameterRaw(2) == 0) { + if (GetParameterAsFloat(2) <= 0.01f) { mod = 0.5f; m_pan = mod; } diff --git a/Software/GuitarPedal/Effect-Modules/multi_delay_module.cpp b/Software/GuitarPedal/Effect-Modules/multi_delay_module.cpp index 59b61f2..cc8594b 100644 --- a/Software/GuitarPedal/Effect-Modules/multi_delay_module.cpp +++ b/Software/GuitarPedal/Effect-Modules/multi_delay_module.cpp @@ -43,7 +43,7 @@ static const ParameterMetaData s_metaData[s_paramCount] = {{ knobMapping : 0, midiCCMapping : 20, minValue : 0, - maxValue : 100 + maxValue : 1 }, { name : "Delay L ms", @@ -75,7 +75,7 @@ static const ParameterMetaData s_metaData[s_paramCount] = {{ knobMapping : 3, midiCCMapping : 31, minValue : 0, - maxValue : 100, + maxValue : 1, }, { name : "Tap Mode", diff --git a/Software/GuitarPedal/Effect-Modules/reverb_delay_module.cpp b/Software/GuitarPedal/Effect-Modules/reverb_delay_module.cpp index 09bf60e..e225a37 100644 --- a/Software/GuitarPedal/Effect-Modules/reverb_delay_module.cpp +++ b/Software/GuitarPedal/Effect-Modules/reverb_delay_module.cpp @@ -406,7 +406,7 @@ void ReverbDelayModule::ProcessMono(float in) { // Calculate any delay spread delaySpread.delayTarget = m_delaySpreadMin + (m_delaySpreadMax - m_delaySpreadMin) * GetParameterAsFloat(11); float delSpread_out = delaySpread.Process(delRight_out); - if (GetParameterRaw(11) > 0 && !GetParameterAsBool(12)) { + if (GetParameterAsFloat(11) > 0.0f && !GetParameterAsBool(12)) { delRight_out = delSpread_out; } @@ -494,7 +494,7 @@ void ReverbDelayModule::ProcessStereo(float inL, float inR) { // Calculate any delay spread delaySpread.delayTarget = m_delaySpreadMin + (m_delaySpreadMax - m_delaySpreadMin) * GetParameterAsFloat(11); float delSpread_out = delaySpread.Process(delRight_out); - if (GetParameterRaw(11) > 0 && !GetParameterAsBool(12)) { // If spread > 0 and dual delay isn't on + if (GetParameterAsFloat(11) > 0.0f && !GetParameterAsBool(12)) { // If spread > 0 and dual delay isn't on delRight_out = delSpread_out; }