Refactors for safety and ability to use different curve for float parameters #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xconverge
commented
Dec 31, 2024
| @@ -539,18 +539,20 @@ void ReverbDelayModule::SetTempo(uint32_t bpm) { | |||
| UpdateLEDRate(); | |||
| } | |||
|
|
|||
| float ReverbDelayModule::GetBrightnessForLED(int led_id) { | |||
| float ReverbDelayModule::GetBrightnessForLED(int led_id) const { | |||
| float value = BaseEffectModule::GetBrightnessForLED(led_id); | |||
|
|
|||
| float osc_val = led_osc.Process(); | |||
There was a problem hiding this comment.
I didn't really know how to refactor this/want to test it so I just made led_osc mutable since it seems to only be used for the LED
xconverge
changed the title
xconverge
commented
Dec 31, 2024
| @@ -253,9 +262,29 @@ void BaseEffectModule::SetParameterAsMagnitude(int parameter_id, float value) { | |||
| return; | |||
| } | |||
|
|
|||
There was a problem hiding this comment.
this chunk is the main implementation change
…int of the knob when using logarithmic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48