Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Actions packaging quilt tests #23

Closed
wants to merge 22 commits into from
Closed

Actions packaging quilt tests #23

wants to merge 22 commits into from

Conversation

blackboxsw
Copy link
Owner

Proposed Commit Message

<type>(optional scope): <summary>  # no more than 72 characters

A description of what the change being made is and why it is being
made if the summary line is insufficient.  This should be wrapped at
72 characters.

If you need to write multiple paragraphs, feel free.

Fixes GH-NNNNN (GitHub Issue number. Remove line if irrelevant)
LP: #NNNNNN (Launchpad bug number. Remove line if irrelevant)

Additional Context

Test Steps

Merge type

  • Squash merge using "Proposed Commit Message"
  • Rebase and merge unique commits. Requires commit messages per-commit each referencing the pull request number (#<PR_NUM>)

blackboxsw and others added 21 commits August 7, 2024 10:19
@blackboxsw
feat(snap): avoid refresh on package_upgrade: true and refresh.hold (c…
0787d62 
…anonical#5426)

When snap refresh.hold is set to forever, an admin is saying they do
not want generic automated refreshes of snaps performed by default.

This should be an indicator to cloud-init to avoid calling snap refresh
on such systems due to a `package_upgrade: true` present in user-data.

For network-limited environments with images which have the snap package
manager but don't want to wait and timeout on snap refresh, the following
user-data can be provided to still allow for package_upgrade: true,
and avoid a 20-30 second wait on snaps being unable to access certain
snap URLs.

   #cloud-config
   package_upgrade: true
   snap:
     commands:
       00: snap refresh --hold=forever

cloud-init now interrogates the state refresh.hold value by calling
  snap get system -d

If snap refresh --hold was called in that environment to set 'forever',
cloud-init will skip calling refresh and log the reason for skipping.

We cannot honor short time-based refresh.holds because the snap
services place a short hold in early boot anyway as systemd units
startup.

Fixes: canonicalGH-5290
@blackboxsw
fix: read_optional_seed to set network-config when present (canonical…
edd92b7 
…#5593)

Commit 5322dca added network-config support to nocloud's
read_optional_seed function. It persisted meta-data as
network-config. Add tests and fix to track network-config value.
@PengpengSun
Revert "fix(vmware): Set IPv6 to dhcp when there is no IPv6 addr (can…
65014b9 
…onical#5471)" (canonical#5596)

This reverts commit 2b6fe64.

When there is no IPv6 set to dhcp explicitly, NetworkManager keyfile
defaults to method=auto, may-fail=true. When there is Ipv6 set to dhcp
explictily, NetworkManager keyfile will be set to
method=auto, may-fail=false. The default settings are what we want, so
revert the previous change to keep IPv6 not set explicitly.
@ani-sinha
chore: add comment explaining the NetworkManager may-fail setting (ca…
e3db1ad 
…nonical#5598)

chore: add comment explaining the NetworkManager may-fail setting

The value of may-fail in network manager keyfile is a source of
confusion as the default value of it is True for Network Manager and
False for network manager renderer implementation. Add a comment to
explain why the renderer sets may-fail to False in its implementation.
@holmanb
chore: Deprecate old commands in help output (canonical#5595)
bd6cd1f
@holmanb
doc: Describe all stages in a single process (canonical#5595)
6ae8f68
@holmanb
doc(boot): Make first boot a dedicated page (canonical#5595)
0014467 
Also shift the format page higher in the explanation page list, since
this is a high traffic page.
@holmanb
doc: Add misc links, improve wording (canonical#5595)
baeb35c
@blackboxsw
chore(actions): add doc label for any doc related subdir file matches (…
4c96055 
…canonical#5602)

Recently noticed that doc file changes in nested subdirs were
not triggering documentation auto label.

Example of subdir match at
https://github.com/actions/labeler?tab=readme-ov-file#basic-examples
@aciba90
chore: explain other use of oauth (canonical#5616)
8b11d99
@holmanb
docs: Drop Python 3.6 and 3.7 support (canonical#5617)
14edf67
@holmanb
docs: Remove unnecessary section, add feature flag page (canonical#5617)
07d0384
@holmanb
fix(btrfs): Version parsing (canonical#5618)
dfcc2b8 
Fixes canonicalGH-5614
@nmeyerhans
fix(systemd): Correct location of installed drop-in files(canonical#5615
ac94539 
)

As noted in the systemd documentation, /etc is reserved for "System
units created by the administrator" while the lib directory should be
used by "System units installed by the distribution package manager".

Fixes canonicalGH-5613
@holmanb
chore(mypy): Lint log module (canonical#5607)
19a9cca
@holmanb
chore(tox.ini): Simplify configuration, fix minor bugs (canonical#5607)
56dc23c 
When referencing a command from another environment, it will cause
errors when the other environment already exists. Fix it by avoiding
indirection in environment command definitions.

Additionally, simplify envoronment dependency management by defining two
lists of dependencies: a default one with pinned versions for all
environments, and an unpinned on for "tip" environments. Several
dependencies have been missed in the mypy envornments, so this should
make it easier by standardizing environment dependencies to be
consistent across environments.
@holmanb
chore(mypy): Fix failures on newer versions of mypy (canonical#5607)
2bb49b4
@holmanb
chore(black): Bump version (canonical#5607)
56658ec
@holmanb
ci: Drop Python 3.6 and 3.7 (canonical#5607)
e1845be 
Bump Ubuntu version for better pip dependency resolution.
@jcmoore3
Update behavior of base bond interface with NetworkManager (canonical…
90a3190 
…#5385)

When using NetworkManager, if the base bond interface does not have
subnet information configured, ensure it is disabled with respect to
ipv4 and ipv6. Otherwise, the base bond interface defaults to 'auto'
and will try to configure itself via DHCP. This is problematic when
using a tagged VLAN interface on top of the bond as the base
interface will try to configure itself via DHCP on the untagged VLAN.
@jcmoore3
fix(nm): Ensure bond property name formatting matches schema definiti…
d79050d 
…on (canonical#5383)

The cloud-init network config version 1 schema defines the bond
properties with underscores, prepended with 'bond-'. This change
ensures consistency with the schema for the bond property names.

canonicalGH-5366
@blackboxsw blackboxsw changed the base branch from main to ubuntu/noble August 14, 2024 22:36
@blackboxsw blackboxsw force-pushed the actions-packaging-quilt-tests branch from 3befdd7 to c6afa08 Compare August 15, 2024 04:10
@blackboxsw blackboxsw force-pushed the actions-packaging-quilt-tests branch from c6afa08 to bef6e5c Compare August 15, 2024 04:11
@blackboxsw blackboxsw closed this Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@blackboxsw @PengpengSun @ani-sinha @holmanb @aciba90 @nmeyerhans @jcmoore3