Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor UI fixes: Search + Versions panel #1208

Merged
merged 4 commits into from
Jun 14, 2024

Conversation

OlegMoshkovich
Copy link
Member

@OlegMoshkovich OlegMoshkovich commented Jun 4, 2024

This PR:

  • Sets the width of the search bar to match the width of other panels.
  • Adds an adornment to the TextField component of the search bar to clear the input, ensuring the search string does not overlap with the clear icon.
  • Sets the search TextField to multiline to accommodate long GitHub strings.
  • Moves the versions panel to the same location as the nav tree panel.

Updated

percy

@OlegMoshkovich OlegMoshkovich added the bug Something isn't working label Jun 4, 2024
@OlegMoshkovich OlegMoshkovich self-assigned this Jun 4, 2024
Copy link

netlify bot commented Jun 4, 2024

👷 Deploy request for bldrs-share pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 2e7b741

Copy link

netlify bot commented Jun 4, 2024

Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit aafc39b
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/666c6ca24250f1000844f3fb
😎 Deploy Preview https://deploy-preview-1208--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 17 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@pablo-mayrgundter pablo-mayrgundter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code ok, let's see percy for UI change comparison

@pablo-mayrgundter
Copy link
Member

I don't see any changes to search in Percy. Shouldn't we see them in the search-100 tests?

@pablo-mayrgundter
Copy link
Member

Oh whoops, I do see it. But also a flake. Can you add waits for those to deflake?

This is the intended change:
image

These are the flakes:
image

@OlegMoshkovich
Copy link
Member Author

OlegMoshkovich commented Jun 5, 2024

@pablo-mayrgundter notes tests should not be a part of this PR.
It should be addressed separately, will create a ticket.
Issue:
#1216

Updated percy run - PTAL

Copy link
Contributor

@nickcastel50 nickcastel50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member Author

@OlegMoshkovich OlegMoshkovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a ticket to deal with notes percy flakes.

@OlegMoshkovich OlegMoshkovich merged commit 6a3a438 into bldrs-ai:main Jun 14, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants