-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor UI fixes: Search + Versions panel #1208
Minor UI fixes: Search + Versions panel #1208
Conversation
👷 Deploy request for bldrs-share pending review.Visit the deploys page to approve it
|
✅ Deploy Preview for bldrs-share ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code ok, let's see percy for UI change comparison
I don't see any changes to search in Percy. Shouldn't we see them in the search-100 tests? |
@pablo-mayrgundter notes tests should not be a part of this PR. Updated percy run - PTAL |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Created a ticket to deal with notes percy flakes.
This PR:
Updated
percy