Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic octokit instantiation based on auth status #1248

Merged
merged 7 commits into from
Aug 9, 2024

Conversation

nickcastel50
Copy link
Contributor

  • Dynamic octokit instantiation based on auth status, we probably don't want to use the proxy for unearthed requests due to rate limiting.

@nickcastel50 nickcastel50 added the enhancement New feature or request label Jul 25, 2024
@nickcastel50 nickcastel50 self-assigned this Jul 25, 2024
Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit cfd63f6
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/66b58b1cb7edb600081b2e50
😎 Deploy Preview https://deploy-preview-1248--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 17 (no change from production)
Accessibility: 91 (no change from production)
Best Practices: 92 (no change from production)
SEO: 100 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jul 25, 2024

Deploy Preview for bldrs-share-v2 ready!

Name Link
🔨 Latest commit cfd63f6
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share-v2/deploys/66b58b1c6a3c150008c3a462
😎 Deploy Preview https://deploy-preview-1248--bldrs-share-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@pablo-mayrgundter pablo-mayrgundter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's figure out a way to test this. Should need some new hooks in msw? for new non-auth'd paths

Signed-off-by: nickcastel50 <nickcastel50@gmail.com>
@nickcastel50 nickcastel50 merged commit 573eca6 into bldrs-ai:main Aug 9, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants