Dialog+tabs

[pablo-mayrgundter]

Changes:

• DialogTabs
  • Changed name to TabbedDialog
  • Remove actions to be part of content; not sure about this
  • Make more params optional
  • Changed param names; part to follow convention, part opinion.. see what you think
  • Bunch of typo fixes
• Simplify fixture setup

https://deploy-preview-782--bldrs-share.netlify.app/cosmos/?fixtureId=%7B%22path%22%3A%22src%2FComponents%2FTabbedDialog.fixture.jsx%22%7D

[netlify]

✅ Deploy Preview for bldrs-share ready!

Name	Link
🔨 Latest commit	877a6a1
🔍 Latest deploy log	https://app.netlify.com/sites/bldrs-share/deploys/64de7e254cf1970008909567
😎 Deploy Preview	https://deploy-preview-782--bldrs-share.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[OlegMoshkovich]

Much cleaner props!
Regarding the action button, if we remove it, we break MUI convention.
I thought we decided to stick to it, so it is more cohesive.
Having the button in the dialog actions also takes care of the spacing issue, that way it is always in the same place.

This is the design using MUI current system.
https://www.figma.com/file/DqKVaQEukf8vVHnlwiRGhv/Screens?type=design&node-id=2362-16501&mode=design&t=q4QyRjLNsdaT4r9i-0
What do you think about implementing it exactly as it is specified?

This is the master component sheet for the dialog:
https://www.figma.com/file/0WnF8npo2MGNmSgKKtnPuo/MUI-for-Figma-Material-UI-v5.14.0?type=design&node-id=6586-47137&mode=design&t=1s6f2SCSWGYpzfkk-0

[pablo-mayrgundter]

Ok, moved DialogActions back in. PTAL

[OlegMoshkovich]

title disappeared.

[pablo-mayrgundter]

whoops, thanks! ptal

[OlegMoshkovich]

Several comments.

[pablo-mayrgundter]

PTAL

[pablo-mayrgundter]

Cypress is either stuck or taking too long to run. I just ran locally no issues. Submitting.