Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify style #784

Merged
merged 8 commits into from
Sep 14, 2023
Merged

Simplify style #784

merged 8 commits into from
Sep 14, 2023

Conversation

OlegMoshkovich
Copy link
Member

This PR is meant to simplify styles to follow MUI conventions.

@OlegMoshkovich OlegMoshkovich marked this pull request as ready for review August 15, 2023 19:14
@netlify
Copy link

netlify bot commented Aug 15, 2023

Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit f9da018
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/650311f635b8df000898e3f3
😎 Deploy Preview https://deploy-preview-784--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 25 (🔴 down 2 from production)
Accessibility: 82 (🟢 up 1 from production)
Best Practices: 92 (🔴 down 8 from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link
Member

@pablo-mayrgundter pablo-mayrgundter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

As discussed:

  • Add padding below dialog buttons
  • Shared corner style for Notes and other components

Let me take one more look when you've done this to QA

Also as separate PR, let's move to mui icons

@oogali
Copy link
Contributor

oogali commented Aug 16, 2023

FYI, this is failing tests because you've changed the label for the sample IFC models.

The E2E tests are looking for Sample Projects, so you'll need to update the tests with the new label value.

@OlegMoshkovich
Copy link
Member Author

OlegMoshkovich commented Aug 17, 2023

@oogali changed the labels for the sample project, but the tests are still failing.
image

Copy link
Member Author

@OlegMoshkovich OlegMoshkovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

Getting a lot of errors related to loaders.
@pablo-mayrgundter can you please take a look, when you have a chance, if it is not too distracting.

@pablo-mayrgundter
Copy link
Member

image Getting a lot of errors related to loaders. @pablo-mayrgundter can you please take a look, when you have a chance, if it is not too distracting.

Can you send more context? I just checked out this PR and it builds and tests fine.

@OlegMoshkovich OlegMoshkovich force-pushed the SimpleStyles branch 3 times, most recently from af1a913 to a2c95df Compare September 12, 2023 11:22
@OlegMoshkovich
Copy link
Member Author

@pablo-mayrgundter PTAL
image
Fix the end to end test error on linux, but there is another error on windows that I am not sure about.

@OlegMoshkovich
Copy link
Member Author

@pablo-mayrgundter PTAL - all the tests are passing and the branch is up to date.

@pablo-mayrgundter
Copy link
Member

Only quirk is not all boxes have same corners. In NavTree, the TreeItems are still rounded.

I personally prefer keeping the rounding on text at least. Perhaps also on buttons.

Also would be nice to have Open tooltip line up to either cover "Search" or line up nicely

Go ahead and submit if you'd like and we can fix these up after

Copy link
Member

@pablo-mayrgundter pablo-mayrgundter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my last comment

@OlegMoshkovich OlegMoshkovich merged commit 0ffb1c7 into bldrs-ai:main Sep 14, 2023
8 checks passed
@OlegMoshkovich OlegMoshkovich deleted the SimpleStyles branch November 8, 2023 10:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants