Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update esbuild dependency #806

Closed
wants to merge 8 commits into from
Closed

Conversation

oo-bldrs
Copy link
Contributor

@oo-bldrs oo-bldrs commented Oct 12, 2023

PR to update our esbuild dependency from 0.15.5 (August 16, 2022) to the latest release 0.19.4 (September 27, 2023).

There have been a number of bug fixes and performance enhancements between the two releases that we can benefit from.

Configuration values with undefined values are no longer permitted and that necessitates a slight change on our side.

Live reload is natively supported by esbuild now (evanw/esbuild#2816).

yarn run v1.22.18
$ yarn build-share-conway && USE_WEBIFC_SHIM=true node config/serve.js
$ USE_WEBIFC_SHIM=true yarn build-share && yarn build-share-copy-web-asm-conway
$ yarn write-new-version && node config/build.js
$ node src/utils/version.mjs > package.json.new && shx mv package.json.new package.json
Using Conway shim backend
⠴ Building

  docs/index.js      13.9mb ⚠️
  docs/index.js.map  22.8mb
✔ Build successful
Build succeeded.
$ shx cp node_modules/bldrs-conway/compiled/dependencies/conway-geom/Dist/*.wasm docs/static/js
Using Conway shim backend
Using Conway shim backend
⠋ Building

 > Local:   http://127.0.0.1:8080/
 > Network: http://192.168.1.2:8080/
✔ Build successful
[watch] build finished, watching for changes...
✔ Build successful
✔ Build successful
✔ Build successful
[watch] build started (change: "src/Components/OperationsGroup.jsx")
✔ Build successful
[watch] build finished
✔ Build successful

@netlify
Copy link

netlify bot commented Oct 12, 2023

Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit f95ff16
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/652949456a601f00082b35ac
😎 Deploy Preview https://deploy-preview-806--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 25 (🔴 down 2 from production)
Accessibility: 84 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 12, 2023

Deploy Preview for bldrs-share-v2 ready!

Name Link
🔨 Latest commit f95ff16
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share-v2/deploys/6529494507fb94000816f907
😎 Deploy Preview https://deploy-preview-806--bldrs-share-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@oo-bldrs oo-bldrs marked this pull request as draft October 13, 2023 15:26
@pablo-mayrgundter
Copy link
Member

Hey dude, shall we close this out? We're up-to-date now

@oo-bldrs
Copy link
Contributor Author

Hey dude, shall we close this out? We're up-to-date now

It depends on whether your esbuild updates incorporate live reload?

@pablo-mayrgundter
Copy link
Member

Hey dude, shall we close this out? We're up-to-date now

It depends on whether your esbuild updates incorporate live reload?

Sure, let's try it. Can you refactor this in place and I'll test it locally as well?

I couldn't get rid of the frequent rebuilds being console logged. Tho maybe that's telling us something useful too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants