Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip sample model load E2E tests #807

Merged
merged 2 commits into from
Oct 12, 2023

Conversation

oo-bldrs
Copy link
Contributor

PR to temporarily disable a problematic test until we have more time to investigate and/or refactor.

@netlify
Copy link

netlify bot commented Oct 12, 2023

Deploy Preview for bldrs-share ready!

Name Link
🔨 Latest commit feb47ab
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share/deploys/65280239856bff0008f7e31c
😎 Deploy Preview https://deploy-preview-807--bldrs-share.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 26 (🔴 down 1 from production)
Accessibility: 84 (no change from production)
Best Practices: 100 (no change from production)
SEO: 92 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@netlify
Copy link

netlify bot commented Oct 12, 2023

Deploy Preview for bldrs-share-v2 ready!

Name Link
🔨 Latest commit feb47ab
🔍 Latest deploy log https://app.netlify.com/sites/bldrs-share-v2/deploys/65280239cc0c780008fd08fd
😎 Deploy Preview https://deploy-preview-807--bldrs-share-v2.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Furthermore, this entire test suite needs to be refactored because each test relies on behavior from previous tests. This current state makes future parallelization impossible.

Instead, each test should set up its expected environment prior to performing its actions and assertions. If it's a setup that is shared amongst multiple tests then that can be placed in a `beforeEach` block or something similar.
@oo-bldrs oo-bldrs merged commit b87d2b3 into bldrs-ai:main Oct 12, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant