fix(epub, word): Update the documents cache whenever the file is modified #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
fixes #288
Summary of the issue:
Certain document formats, as of now only word and epub, cache their HTML representation to be loaded in subsequent reads. However, the cache was not properly updated whenever the document itself would change
Description of how this pull request fixes the issue:
We now also keep track of the document's modified time, and update the cache accordingly if the document appears to be modified.
The check we do is probably very naive, but the use case is simplistic enough that it shouldn't matter.
Testing performed:
Unit tests were added
Known issues with pull request:
None that I could see