Update/cypress test isolation #1116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simplify tests when possible and add mobile nav test
* develop: (45 commits) Rollback ecommerce nodule npm package Bump plugin version Modify composer deps linting fixes fixes in store page linting fixes linting issues calling comingSoonAdminbarToggle on update of comingsoon update tests to reflect change remove 'FREE Monthly Webinar: ' line from webinar component update migration module to 1.0.7 update features module to 1.4.2 update plugin version to 3.12.1 Replace references to old values in `NewfoldRuntime` require migration update 1.0.6 in plugin Bump coming soon module to 1.2.5 Bump version Bump module version Bump module version Fix merge conflict ...
* develop: (331 commits) update solutions module to 1.0.6 try tests with updated data and solutions modules update data module to 2.6.6 update ecommerce module to 1.4.3 - fixes migration tests update solutions module to 1.0.5 - fixes tests and flaky api call NPM(deps): Bump react-router-dom from 6.27.0 to 6.28.0 update notifications module to 1.6.4 - fixes test issues update ecommerce module to 1.4.2 - fixes migration test update to minor newfold modules to fix tests also try updating help center module to version 2.2.0 update i18n update notifications module to 1.6.2 try updating wp/scripts to latest update plugin version to 3.15.3 NPM(deps): Bump @wordpress/compose from 7.10.0 to 7.11.0 NPM(deps): Bump @wordpress/i18n from 5.10.0 to 5.11.0 NPM(deps): Bump @wordpress/element from 6.10.0 to 6.11.0 NPM(deps): Bump @wordpress/html-entities from 4.9.0 to 4.11.0 Composer(deps): Bump newfold-labs/wp-module-solutions NPM(deps): Bump @wordpress/dom-ready from 4.10.0 to 4.11.0 ... # Conflicts: # tests/cypress/integration/pages-and-posts.cy.js # tests/cypress/integration/settings.cy.js
Bluehost Brand Plugin
|
||||||||||||||||||||||||||||
| Project |
Bluehost Brand Plugin
|
| Branch Review |
update/cypress-test-isolation
|
| Run status |
|
| Run duration | 30m 15s |
| Commit |
|
| Committer | Evan Mullins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
1
|
Pending
|
33
|
Skipped
|
0
|
Passing
|
410
|
| View all changes introduced in this branch ↗︎ | |
Bluehost Brand Plugin
|
||||||||||||||||||||||||||||
| Project |
Bluehost Brand Plugin
|
| Branch Review |
update/cypress-test-isolation
|
| Run status |
|
| Run duration | 31m 41s |
| Commit |
|
| Committer | Evan Mullins |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
1
|
|
Pending
|
33
|
|
Skipped
|
0
|
|
Passing
|
410
|
| View all changes introduced in this branch ↗︎ | |
circlecube
modified the milestones:
November 13, 2024 Release,
November 20, 2024 Release
wpalani
approved these changes
Nov 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This updates the test files in the plugin to run in testIsolation mode.
Also updates the loginAlso adds a login command to each test in thebeforein support/index to abeforeEachso that each isolated test will login.beforeEachsection.I also updated a few tests to minimize the time it takes to run, and added a mobile nav test since we hadn't done that since the redesign.
Once these are all passing and merged, we can then add the
testIsolationflag to modules one at a time until they are all in place, at which point we can remove them all and remove the global config that disables testIsolation:testIsolation: false,at https://github.com/bluehost/bluehost-wordpress-plugin/blob/main/cypress.config.js#L73. There's probably a better process to migrate to this config change, but that's the first that comes to mind. If we get to a tipping point we can remove the global config and require any test that doesn't work in isolation mode to specify in thedescribe.To make a test run in testIsolation mode, add it to the options in the describe.
Type of Change
Checklist
Further comments