Coming soon section flow revamp #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In the `SectionContent` component, we are adding a new optional `id` prop. - In the `SectionContent` component, we are tracking url params and looking for `target`. - If the value of the target param matches the passed value in the `id` prop, we'll temporarily add a blink animation. - We are also updating the coming soon section title as per this ticket: https://jira.newfold.com/projects/PRESS1/issues/PRESS1-161
Accidentally pushed my local's cypress configs
|
1 replays were recorded for 58d39b8.
|
wpalani
added a commit
to newfold-labs/wp-module-coming-soon
that referenced
this pull request
Oct 4, 2023
This is part of this PR: bluehost/bluehost-wordpress-plugin#706 We are changing the coming soon section title from 'Maintenance Mode' to 'Site Status: ${status}'.
|
Coming Soon Module PR: newfold-labs/wp-module-coming-soon#13 |
circlecube
approved these changes
Oct 4, 2023
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
In the
SectionContentcomponent, we are adding a new optionalidprop.In the
SectionContentcomponent, we are tracking url params and looking fortarget.If the value of the target param matches the passed value in the
idprop, we'll temporarily add a blink animation.We are also updating the coming soon section title as per this ticket: https://jira.newfold.com/projects/PRESS1/issues/PRESS1-161
We still need to push an update to the coming soon / ecomm modules to update the referrer link to include the URL params.
Demo
Bluehost-Plugin.-.mp4
Type of Change
Checklist
Further comments