Wrap cairo.Surface in a GObject #2104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sure, why not? 👍 |
Drops the need to store the Gtk.IconInfo
infirit
force-pushed
the
surfacegobject
branch
from
63d2564
to
85d5b6a
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
infirit
changed the title
cschramm
approved these changes
Aug 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore the other commit (it's bed time so I left it in).
How about we handle the surface like this? When I added the scaling I wasn't smart enough to figure out how to get the surface in the store. It's not perfect but it works well enough and simplifies things.