Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes from stable #2337

Merged
merged 7 commits into from
Sep 27, 2024
Merged

Fixes from stable #2337

merged 7 commits into from
Sep 27, 2024

Conversation

infirit
Copy link
Contributor

@infirit infirit commented Apr 8, 2024

No description provided.

Copy link

sonarcloud bot commented Apr 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@infirit infirit force-pushed the fromstable branch 2 times, most recently from 2d9322c to 71d7006 Compare May 15, 2024 17:56
@infirit infirit marked this pull request as ready for review May 15, 2024 17:57
@infirit infirit requested a review from cschramm May 15, 2024 17:58
@infirit
Copy link
Contributor Author

infirit commented May 15, 2024

Picked the remaining commits that only exist in stable + extra dist the meson_options

@cschramm
Copy link
Member

#2334 is missing

@infirit
Copy link
Contributor Author

infirit commented May 15, 2024

Added that one.

Copy link

sonarcloud bot commented May 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@infirit infirit enabled auto-merge (rebase) May 17, 2024 15:38
@cschramm
Copy link
Member

#2364

@cschramm
Copy link
Member

ping

@infirit
Copy link
Contributor Author

infirit commented Sep 18, 2024

Completely forgot about this one 😅 . I'll go over this over the weekend to make sure I didn't miss anything.

infirit and others added 7 commits September 19, 2024 20:44
We build a (32 bit) ID for the menu item from its priority values, using the sub priority as the lower 8 bits. Pulseaudio card indexes are theoretically 32 bit and PipeWire re-assignes them with large gaps on re-connect so that it provides high 3-digit numbers in practice that do not fit the 8 bits.

Closes blueman-project#2331
kded6 provides an `org.kde.StatusNotifierWatcher` service without its usual `/StatusNotifierWatcher` object if Plasma Workspace's StatusNotifierWatcher module is registered but not loaded (https://invent.kde.org/plasma/plasma-workspace/-/merge_requests/3301). We thus cannot just assume the whole service to be unavailable if the registration fails as we restart the tray application when the name appears.

This is a problem if the Plasma Workspace is around especially on i3 where no other application registers `org.kde.StatusNotifierWatcher`.

Closes blueman-project#2311
I hope this makes things clearer and avoids confusion due to the change from 2.3 to 2.4.

Closes blueman-project#2328
Copy link

sonarcloud bot commented Sep 19, 2024

@infirit
Copy link
Contributor Author

infirit commented Sep 19, 2024

#2364

Added this one and I don't see any others missing.

@infirit infirit merged commit 97eaf6a into blueman-project:main Sep 27, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants