meson: Do not emit absolute path when S != B #2461
Conversation
|
This broke the meson build, cannyou check. Regardless, please use https://mesonbuild.com/Reference-manual_functions.html#join_paths |
|
Also ideally we use mesons native cython support 1, but when I tried I ran into meson errors and put it on hold |
kraj
force-pushed
the
main
branch
2 times, most recently
from
99f8cc8
to
bd16da4
Compare
build systems like OE build outside sourcetree in such cases it works ok but cython resolves the input file to absolute path and that gets emitted into genetate _blueman.c as module name, renders the build non-reproducible, wish cython had a better way to handle this but there is not, therefore tweak the meson build rule to account for specifying workdir to cython which will search the inputs correctly, and use meson's build_root to emit the output into build dir. This ensures that it becomes independent of source or build directories and cython does not generate the absolute paths into generate C code. See cython discussion on [1] [1] cython/cython#5949 Signed-off-by: Khem Raj <raj.khem@gmail.com>
kraj
changed the title
done. |
yeah I needed to make input relative to buildroot as well. Fixed now.
|
|
build systems like OE build outside sourcetree in such cases it works ok but cython resolves the input file to absolute path and that gets emitted into genetate _blueman.c as module name, renders the build non-reproducible, wish cython had a better way to handle this but there is not, therefore tweak the meson build rule to account for specifying workdir to cython which will search the inputs correctly, and use meson's build_root to emit the output into build dir. This ensures that it becomes independent of source or build directories and cython does not generate the absolute paths into generate C code.
See cython discussion on [1]
[1] cython/cython#5949