-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set Inter to use ss02 disambiguation styleset #6129
base: main
Are you sure you want to change the base?
Conversation
542923f
to
ad69ccb
Compare
Another less disruptive option is to use Gitlab used that for their version of Inter: character variants aren't in the react native fontVariant though... |
If this is not a desired change, I'm happy to close this out. |
c344a3d
to
6c1eda6
Compare
this needs a look from @estrattonbailey |
eafa6b3
to
f8c4674
Compare
14156c0
to
e81e757
Compare
e81e757
to
a9da888
Compare
Hey sorry for the delay. I like the idea, I tend to prefer these too. Other users may have differing opinions, but I'd be curious to try this. At the very least the lower L variant (I kinda think the I with bars is ugly heh). I had to timebox this today, got some other stuff to get done this weekend, but did a little poking so I better understand. It does appear that RNW doesn't support So it seems the full situation is:
Not sure if/when we'll get time to dig deeper, but happy to review code or lend an ear if you want to keep looking into this! |
a9da888
to
6474deb
Compare
I think I will poke around a bit on patching RN and RNW for this when I find some time. |
bcce3e7
to
f34ab59
Compare
add ss02 to fonts this isn't working on web and i don't know why add ss02 to templates/fallback styles
f34ab59
to
720b782
Compare
This adds ss02 to Inter which is the disambiguation set https://rsms.me/inter/#features
It makes ILli1 a lot easier to tell apart.
Haven't been able to get this working on web. Seems that some react-native-web styles are overriding it and the font-feature-settings aren't getting applied correctly.
Looks great on android though
Thread with some more info
https://bsky.app/profile/benharri.org/post/3l7r4sv42sk2q