Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add NotRequired things to the DataKey schema #309

Closed
coretl opened this issue Jun 3, 2024 · 1 comment · Fixed by #313
Closed

Add NotRequired things to the DataKey schema #309

coretl opened this issue Jun 3, 2024 · 1 comment · Fixed by #313
Assignees
@evalott100

Comments

@coretl
Copy link
Contributor

coretl commented Jun 3, 2024

As per bluesky/ophyd-async#137 (comment)

Also removing the Optional from "units" and "precision"

event-model/event_model/documents/event_descriptor.py

Line 59 in fc6e30e

Annotated[Optional[str], Field(description="Engineering units of the value")]

@coretl
Copy link
Contributor Author

coretl commented Sep 16, 2024

Also choices

@evalott100 evalott100 mentioned this issue Sep 17, 2024
Merged
@evalott100 evalott100 linked a pull request Sep 18, 2024 that will close this issue
removed Optional on the specified datakey fields #313
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@evalott100 evalott100

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

removed Optional on the specified datakey fields bluesky/event-model
2 participants
@evalott100 @coretl