Rethinking external assets #270
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tests for generating json schema from those TypedDicts
…general, working on typing everything to be mypy compliant
…uired now. Two json contain an error where they are missing some details
… to split them into total=False
…ter idea to just add the compose_ functions manually. This commit is just so I can access what I've done for the wrapper in case I change my mind
…alott100/event-model into switch_from_partials_to_classes
…alott100/event-model into switch_from_partials_to_classes
…dd_typing_support_to_event_model
…alott100/event-model into switch_from_partials_to_classes
…alott100/event-model into switch_from_partials_to_classes
…alott100/event-model into switch_from_partials_to_classes
…00/event-model into rethinking_external_assets
This seperation will enable the protocols to import the PartialDocs and for definitions to be more central.
…uction of PartialDoc parents
coretl
reviewed
May 25, 2023
evalott100
force-pushed
the
rethinking_external_assets
branch
from
daa4cfd
to
9ebff1f
Compare
|
Changing to #272 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #236