Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rethinking external assets #270

Closed
wants to merge 56 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
c26bd32
Include importlib-metadata for 3.7.
danielballan Dec 9, 2022
eba4dde
Update CI versions.
danielballan Dec 9, 2022
04199c1
Use importlib-metadata for 3.7.
danielballan Dec 9, 2022
5cbadf1
Specify Python version as string to fix '3.10'.
danielballan Dec 9, 2022
a5dcd2d
Release notes for v1.19.1
danielballan Dec 9, 2022
2e526f5
Fix typo.
danielballan Dec 9, 2022
f33739f
REL: v1.19.1
danielballan Dec 9, 2022
c53a2a8
Added TypedDicts to __init__.py and added the functionality and unit …
evalott100 Jan 13, 2023
5a8ac5b
Merge branch 'master' into 235_add_typing_support_to_event_model
evalott100 Feb 20, 2023
114999f
Fixed conflicts
evalott100 Feb 20, 2023
b746e19
Put extra schema in global dict using class decorator. Cleaned up in …
evalott100 Mar 1, 2023
6801009
Found way to swap Annotated and Optional, not total=False classes req…
evalott100 Mar 6, 2023
c75634f
Got schema generation working with single typeddict, without the need…
evalott100 Mar 13, 2023
46185b5
Nearly finished typeddict conversion of __init__.py
evalott100 Mar 17, 2023
cf5d39c
Finished schema generation and made __init__ mypy complient
evalott100 Mar 20, 2023
fecb729
Massively simplified type parsing
evalott100 Mar 22, 2023
21cbf8f
Converted sub typeddicts into basemodels recursively
evalott100 Apr 4, 2023
6c93708
Merge branch 'master' into 235_add_typing_support_to_event_model
evalott100 Apr 6, 2023
7ad304e
Compatibility with the skeleton merge
evalott100 Apr 6, 2023
b194445
Changed to get mypy CI working
evalott100 Apr 6, 2023
b6b59d0
Added precision and units to the event_descriptor
evalott100 Apr 11, 2023
8b2d8bb
Changed the workflow to add mypy to the linter
evalott100 Apr 11, 2023
a8d00b8
alphabetized the schema
evalott100 Apr 19, 2023
48cb01b
Added global patternProperties
evalott100 Apr 19, 2023
86916ef
Merge branch 'master' into 235_add_typing_support_to_event_model
evalott100 Apr 20, 2023
803a0b1
pulled from upstream
evalott100 May 9, 2023
b4810ff
made mypy complient
evalott100 May 9, 2023
293e69d
Started creating the backwards compatible wrapper, I think it's a bet…
evalott100 May 12, 2023
7f2ce38
wrote manual compose_ wrapper functions
evalott100 May 15, 2023
ce45fce
Started type hinting more fully, will come back to it
evalott100 May 16, 2023
fb2251c
made mypy complient
evalott100 May 9, 2023
143d002
Removed unneccesary changes
evalott100 May 16, 2023
ebfaabd
Fixed CI errors
evalott100 May 16, 2023
2aa12e8
made mypy complient
evalott100 May 9, 2023
35cbcfd
Redid the sorting of the schema
evalott100 May 16, 2023
c00da15
Corrected mypy errors
evalott100 May 17, 2023
7db4bae
Merge branch 'master' into 235_add_typing_support_to_event_model
evalott100 May 17, 2023
32518ae
Fixed merge errors
evalott100 May 17, 2023
8ebf0b6
Merge branch '235_add_typing_support_to_event_model' of github.com:ev…
evalott100 May 17, 2023
6f84dfc
Manually patch in top level additionalProperties: false
evalott100 May 17, 2023
d509a37
Merge branch '235_add_typing_support_to_event_model' of github.com:ev…
evalott100 May 17, 2023
4fafc23
Merge branch 'master' of github.com:evalott100/event-model into 235_a…
evalott100 May 18, 2023
19830f0
Merge branch '235_add_typing_support_to_event_model' of github.com:ev…
evalott100 May 18, 2023
5c8d283
made compatible with new versioning
evalott100 May 18, 2023
cdc49f4
Merge branch '235_add_typing_support_to_event_model' of github.com:ev…
evalott100 May 18, 2023
952657e
Changed the external assets, will need to do so for the bundler side too
evalott100 May 18, 2023
b5ffe55
Minor corrections in event_descriptor, datum_page, and run_start
evalott100 May 19, 2023
884bff4
Merge branch '235_add_typing_support_to_event_model' of github.com:ev…
evalott100 May 19, 2023
3d560f0
Merge branch 'switch_from_partials_to_classes' of github.com:evalott1…
evalott100 May 19, 2023
582d7f3
Minor corrections in event_descriptor, datum_page, and run_start
evalott100 May 19, 2023
2263b2a
Minor corrections in event_descriptor, datum_page, and run_start
evalott100 May 19, 2023
19ed50e
Seperated out a PartialEvent and PartialResource from Event and Resource
evalott100 May 22, 2023
ebe579f
ensure schema required list is sorted too
evalott100 May 22, 2023
c96f31f
sorted required list (order is changed on this branch with the introd…
evalott100 May 22, 2023
9ebff1f
Corrected small error in stream_resource
evalott100 May 30, 2023
9178435
Made changes recommended after the bluesky meeting
evalott100 Jun 2, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/code.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,8 +24,8 @@ jobs:
install_options: -e .[dev]

- name: Lint
run: tox -e pre-commit #, mypy

run: tox -e pre-commit,mypy
test:
if: github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name != github.repository
strategy:
Expand Down
7 changes: 7 additions & 0 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -21,3 +21,10 @@ repos:
language: system
entry: flake8
types: [python]

- id: mypy
name: Run mypy
stages: [commit]
language: system
entry: mypy --install-types --non-interactive
types: [python]
Loading