Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mnt py312 #289

Merged
merged 5 commits into from
Nov 17, 2023
Merged

Mnt py312 #289

merged 5 commits into from
Nov 17, 2023

Conversation

tacaswell
Copy link
Contributor

Description

Drop support for old jsonschema (to drop need to parse version strings)

Motivation and Context

Looking at conda-forge/event-model-feedstock#46 the failures are because our tests use distutils which were removed in py312. The first commit changes to use packgaing.version.parse instead. However, we only need to check version strings to support jsonschema < 3 which at this point is almost 5 years old so I think we can safely require a newer version of jsonschema.

If changing the dep pinning in too aggressive I can drop the second commit.

attn @ZLLentz

How Has This Been Tested?

Copy link
Member

@danielballan danielballan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upon closer inspection, this PR needs to remove the CI jobs targeting jsonschema 2.x

@tacaswell
Copy link
Contributor Author

I 👍🏻 these changes, but can not in the UI because it is my own PR.

@danielballan
Copy link
Member

Thanks @untzag !

@danielballan danielballan merged commit a4829b8 into bluesky:main Nov 17, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants