Update pydantic to v2 #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evalott100
force-pushed
the
update_pydantic_to_v2
branch
8 times, most recently
from
c3c4d07
to
862fafc
Compare
evalott100
commented
Feb 5, 2024
evalott100
force-pushed
the
update_pydantic_to_v2
branch
4 times, most recently
from
e470fda
to
70bf3d5
Compare
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4. - [Release notes](https://github.com/actions/download-artifact/releases) - [Commits](actions/download-artifact@v3...v4) --- updated-dependencies: - dependency-name: actions/download-artifact dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
evalott100
force-pushed
the
update_pydantic_to_v2
branch
4 times, most recently
from
45256ac
to
bcc4434
Compare
danielballan
reviewed
Feb 8, 2024
evalott100
force-pushed
the
update_pydantic_to_v2
branch
from
bcc4434
to
d3f2a58
Compare
The schema generation code now uses pydantic 2, which has been pinned in the `pyproject.toml`.
evalott100
force-pushed
the
update_pydantic_to_v2
branch
from
d3f2a58
to
6c27a91
Compare
danielballan
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changed event model to use pydantic v2. This is now pinned.
Motivation and Context
Since the release of pydantic v2, we've been doing generation code with pydantic 1. Pydantic 2 allows us to do this with less code.
How Has This Been Tested?
Tested against bluesky itself. So long as the schema match up the runtime code should work the same.