-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed Optional
on the specified datakey fields
#313
removed Optional
on the specified datakey fields
#313
Conversation
194e6b4
to
1e3f44a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
#309 isn't a very well written ticket... This PR does half of it.
Please could you make another PR that adds limits
and choices
as per the link in the ticket and make them NotRequired
fields.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't units and precision optional though?
For a str enum precision doesn't make sense- are we just going to say 0 or -1? Empty units for dimensionless things yes
We remove the ability to make them |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That makes sense: precision is still NotRequired but if present is str not str | None
May as well do it here |
Also made `Dtype` accessible from `event_model`
1dcac84
to
72e40cd
Compare
@coretl I think I should maybe make each field |
49a4ab1
to
3ce1f5f
Compare
Also made each field in `LimitsRange` optional.
3ce1f5f
to
2d0bf2d
Compare
Fixes half of #309