-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement precompile contract for opBNB #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
j75689
force-pushed
the
feat/v34-opbnb
branch
2 times, most recently
from
April 12, 2024 01:34
6a05463
to
5cdc813
Compare
Valgrind Results:
|
unclezoro
reviewed
Apr 25, 2024
unclezoro
reviewed
Apr 25, 2024
unclezoro
reviewed
Apr 25, 2024
unclezoro
reviewed
Apr 25, 2024
j75689
force-pushed
the
feat/v34-opbnb
branch
4 times, most recently
from
April 29, 2024 11:39
7f9beee
to
cd58162
Compare
unclezoro
requested changes
May 6, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we need for the cometbft repo.
unclezoro
approved these changes
May 21, 2024
keefel
approved these changes
May 21, 2024
j75689
added a commit
that referenced
this pull request
Jun 3, 2024
* feat: implement precompile contract for opBNB * fix: unused import warning in test * ci: add develop branch to the list of branches to run * chore: fmt codes * chore: fix no default feature importing * chore: cargo clippy fix * ci: disable checks on riscv32imac-unknown-none-elf * chore: setup vec with capacity * fix: cometbft_light_block_validate input conversion * chore: fix fmt * fix: add opbnb feature to ECOTONE * fix: sepc definition * chore: fix opBNB feature tags * chore(ci): bump action/deploy (#1372) * fix: light block header validation in cometbft * chore: fix fmt * fix: BLS_SIGNATURE_VALIDATION_BASE to 1000 * update greenfield-cometbft-rs version --------- Co-authored-by: rakita <rakita@users.noreply.github.com> Co-authored-by: Keefe Liu <keefe.l@users.noreply.github.com>
j75689
added a commit
that referenced
this pull request
Jun 3, 2024
* feat: implement precompile contract for opBNB * fix: unused import warning in test * ci: add develop branch to the list of branches to run * chore: fmt codes * chore: fix no default feature importing * chore: cargo clippy fix * ci: disable checks on riscv32imac-unknown-none-elf * chore: setup vec with capacity * fix: cometbft_light_block_validate input conversion * chore: fix fmt * fix: add opbnb feature to ECOTONE * fix: sepc definition * chore: fix opBNB feature tags * chore(ci): bump action/deploy (#1372) * fix: light block header validation in cometbft * chore: fix fmt * fix: BLS_SIGNATURE_VALIDATION_BASE to 1000 * update greenfield-cometbft-rs version --------- Co-authored-by: rakita <rakita@users.noreply.github.com> Co-authored-by: Keefe Liu <keefe.l@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
implement precompile contract to support opBNB
Fermat
Fork.included:
The opBNB function will only be compiled when the "opbnb" feature is enabled.
Related
bnb-chain/greenfield-cometbft-rs#1