autoscaling.apiVersion

[shcherbak]

apiVersion: "autoscaling/v2beta1" is deprecated, adding value for overriding api version, fore example apiVersion: autoscaling/v2

[bokysan]

Thanks for the update!

What I usually do, however, is to enable automatic version detection, e.g:

{{- if semverCompare ">=1.14-0" .Capabilities.KubeVersion.GitVersion -}}
apiVersion: networking.k8s.io/v1
{{- else -}}
apiVersion: extensions/v1beta1
{{- end }}

This way it makes it easier to deploy charts to different versions of Kubernetes without changes to values.yaml.

If you're willing to make this change, please do let me know. Otherwise I will close this PR and make the change myself.

Thanks.
B

[shcherbak]

@bokysan fixed

[bokysan]

Huh, tests do not go through. We will need to manually add the new schema to the repo as well to make the tests pass.

[shcherbak]

https://github.com/gruntwork-io/terratest did You mentioned this test framework for helm?

[bokysan]

Nope. Check the executed tests.

The code runs through several tests and there resulting schema is validated via kubeval.

Unfortunately, there's no JSON schema for autoscaling/v2 online (and depending on online capabilities is bad if you want to keep your tests independent anyhow) so a schema needs to be uploaded into corresponding folder.

[shcherbak]

@bokysan ok, will take a look tomorrow

[bokysan]

I've pulled this in -- I will add the appropriate json file myself.

[shcherbak]

@bokysan thank you! Sorry for not editing pr, i was too busy last days (

[bokysan]

No prob. I know how it is.