Merge pull request #44 from bold-commerce/INTER-4355

Incorrect Fastlane Address List Rendering on Magento 2.3.5
bold-commerce · Jul 29, 2024 · c5bccc2 · c5bccc2
2 parents 67a6e6a + 737f172
commit c5bccc2
Show file tree

Hide file tree

Showing 5 changed files with 30 additions and 19 deletions.
diff --git a/view/frontend/web/js/action/reset-shipping-address.js b/view/frontend/web/js/action/reset-shipping-address.js
@@ -1,18 +1,25 @@
 define(
     [
-        'Magento_Customer/js/model/address-list',
+        'Magento_Checkout/js/model/quote',
         'Bold_CheckoutPaymentBooster/js/action/show-shipping-address-form'
     ], function (
-        addressList,
-        showShippingAddressForm
+        quote,
+        showShippingAddressForm,
     ) {
         'use strict';
 
         /**
          * Remove shipping address from quote and show new shipping address form action.
          */
         return function () {
-            addressList([]);
+            const quoteShippingAddress = quote.shippingAddress();
+            if (quoteShippingAddress.getType() !== 'fastlane-shipping-address') {
+                return;
+            }
+            quoteShippingAddress.getType = function () {
+                return 'new-customer-address';
+            };
+            quote.shippingAddress(quoteShippingAddress);
             showShippingAddressForm();
         };
     });
diff --git a/view/frontend/web/js/action/set-quote-shipping-address.js b/view/frontend/web/js/action/set-quote-shipping-address.js
@@ -22,7 +22,7 @@ define(
          */
         return function (fastlaneAddress) {
             const shippingAddress = convertFastlaneAddressAction(fastlaneAddress);
-            addressList([shippingAddress]);
+            addressList([]);
             selectShippingAddressAction(shippingAddress);
             checkoutData.setSelectedShippingAddress(shippingAddress.getKey());
             hideShippingAddressFormAction();

diff --git a/view/frontend/web/js/action/show-shipping-address-form.js b/view/frontend/web/js/action/show-shipping-address-form.js
@@ -11,6 +11,9 @@ define(
          */
         return function () {
             const newShippingAddress = registry.get('index = shippingAddress');
+            if (!newShippingAddress) {
+                return;
+            }
             const newShippingAddressFieldset = newShippingAddress.getChild('shipping-address-fieldset');
             newShippingAddress.isFormInline = true;
             if (!newShippingAddressFieldset) {

diff --git a/view/frontend/web/js/view/form/element/email/fastlane-mixin.js b/view/frontend/web/js/view/form/element/email/fastlane-mixin.js
@@ -71,7 +71,6 @@ define(
                         }
                         this.lookupEmail().then(() => {
                             fullScreenLoader.stopLoader();
-                            this.isPasswordVisible(false);
                         }).catch((error) => {
                             fullScreenLoader.stopLoader();
                             console.log(error);
@@ -105,6 +104,7 @@ define(
                                     window.checkoutConfig.bold.fastlane.profileData = profileData;
                                     fullScreenLoader.startLoader();
                                     this.setShippingAddress(profileData);
+                                    this.isPasswordVisible(false);
                                 }
                                 return;
                             }

diff --git a/view/frontend/web/js/view/shipping-address/list.js b/view/frontend/web/js/view/shipping-address/list.js
@@ -5,13 +5,15 @@ define(
         'Magento_Customer/js/model/address-list',
         'Bold_CheckoutPaymentBooster/js/action/show-shipping-address-form',
         'Bold_CheckoutPaymentBooster/js/model/fastlane',
+        'Magento_Checkout/js/model/quote'
     ],
     function (
         ko,
         shippingAddressList,
         customerAddressList,
         showShippingAddressFormAction,
-        fastlane
+        fastlane,
+        quote
     ) {
         'use strict';
 
@@ -38,22 +40,21 @@ define(
                     this.visible(false);
                     return;
                 }
-                customerAddressList.subscribe(function (changes) {
-                        let self = this;
-                        changes.forEach(function (change) {
-                            if (change.status === 'deleted' && customerAddressList().length === 0) {
-                                self.visible(false);
-                                showShippingAddressFormAction();
-                            }
-                        });
-                    },
-                    this,
-                    'arrayChange'
-                );
+                quote.shippingAddress.subscribe(function (address) {
+                    if (address && address.getType() === 'fastlane-shipping-address') {
+                        this.createRendererComponent(address, 0);
+                        return;
+                    }
+                    this.visible(false);
+                    showShippingAddressFormAction();
+                }.bind(this));
             },
 
             /** @inheritdoc */
             createRendererComponent: function (address, index) {
+                if (address.getType() !== 'fastlane-shipping-address') {
+                    return;
+                }
                 this._super(address, index);
                 if (!fastlane.isEnabled()) {
                     this.visible(false);