-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CHK-4315: Implement Express Pay in Cart, Mini Cart & on Product Detail Page #70
Draft
JosephLeedy
wants to merge
12
commits into
main
Choose a base branch
from
CHK-4315-cart-pdp-express-pay
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+858
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated the label to clarify that the setting only applies to the Checkout.
* Add setting for enabling Express Pay in Cart (CHK-6325) * Create Bold Checkout order when cart is loaded (CHK-4601) * Determine Express Pay availability by controller action (CHK-4601) * Render Express Pay buttons on Cart page (CHK-4601) * Hide Express Pay header outside of Checkout (CHK-4601) * Fix 403 error thrown by Checkout AJAX calls in Cart (CHK-4601) * Do not initialize Bold order if Express Pay disabled (CHK-4601)
* Add setting for enabling Express Pay in mini cart (CHK-6325) * Load Express Pay script on all pages (CHK-4599) * Allow Express Pay container ID to be set dynamically (CHK-4599) * Use block alias to determine if Express Pay is enabled (CHK-4599) * Create Bold order when any store page is visited (CHK-4599) * Verify quote vaildity before Bold order creation (CHK-4599) * Check Express Pay enabled in mini cart before render (CHK-4599) * Render Express Pay in mini cart if enabled (CHK-4599) * Remove Express Pay instantiation from global scope (CHK-4599) Allows Express Pay to be called multiple times with different configurations. * Prevent rendering Express Pay in mini cart on cart page (CHK-4599) Due to a technical limitation in the Bold EPS Payments SDK, `renderWalletPayments` can only be called once per page. Subsequent calls cause any previously rendered buttons to removed from the page. * Use allow list to determine when to create Bold order (CHK-4599) Reduces the number of calls made to Bold Checkout Resume Order API. * Allow Bold order to be created in Checkout (CHK-4599) * Prevent rendering Express Pay in mini cart in Checkout (CHK-4599) Due to a technical limitation in the Bold EPS Payments SDK, `renderWalletPayments` can only be called once per page. Subsequent calls cause any previously rendered buttons to removed from the page.
* Add setting for enabling Express Pay on product pages (CHK-6325) * Render Express Pay buttons on product detail pages (CHK-4602) * Prevent initializing Bold EPS order on product pages (CHK-4602) Prevents unnecessary orders from being created in Bold Checkout everytime a product is viewed. * Send empty string to Order Create API if quote ID NULL (CHK-4602) Allows Bold Checkout orders to be created without instantiating a new Magento Quote. * Determine whether to render Express Pay on product page (CHK-4602) * Add parameter for determining if current page is PDP (CHK-4602) * Skip configuration validation if on product page (CHK-4602) * Set currency to default store currency if no quote (CHK-4602) * Only show error if one hasn’t been displayed (CHK-4602) * Pass current product default quantity to Express Pay (CHK-4602) * Provide Add to Cart URL to Express Pay component (CHK-4602) * Add product to cart when payment buttons are clicked (CHK-4602) * Throw error from callbacks if product not added to cart (CHK-4602) Ensures PayPal pop-up is automatically closed and Apple Pay and Google Pay pop-ups aren’t rendered if an error occurs while adding the product to the cart. * Move payment buttons below “Add to Cart” button (CHK-4602) * Fix incorrect selector used to get product quantity (CHK-4602) * Fix logic used to determine single product quantity (CHK-4602) * Only add product quantity if greater than zero (CHK-4602) * Validate product add to cart form before submission (CHK-4602) * Set add to cart data from form values (CHK-4602) Fixes “Please select product option(s)” error for complex products. * Set Pay Later order total from product price (CHK-4602) Fixes incorrect PayPal Pay Later message. * Remove unnecessary logic for single product quantities (CHK-4602) * Load quote from Checkout session if ID not provided (CHK-4602) * Disable redirect during add to cart for Express Pay (CHK-4602) * Fix “Session Expired” error when adding product to cart (CHK-4602) * Remove unnecessary check from on update handler (CHK-4602) * Remove unnecessary blank line from update event handler (CHK-4602) * Invert condition in click event handler (CHK-4602) * Get Apple Pay and Google Pay items after add to cart (CHK-4602) * Get Apple Pay and Google Pay totals after add to cart (CHK-4602) * Wait for product to be added to cart before order update (CHK-4602) * Handle shipping address requirement (CHK-4602) * Remove valid cart check from require order data handler (CHK-4602) * Remove disused parameter from add to cart call (CHK-4602) * Empty cart before adding product via Express Pay (CHK-4602) * Do not provide quote ID to create order API on PDP (CHK-4602) Ensures that the currently active quote is retrieved in case the previous quote was reset. * Fix incorrect handle used to instantiate Config model (CHK-4602) * Add missing parameter to Config model instantiation (CHK-4602) * Add missing newlines to ends of classes (CHK-4602)
…ry Has No Region (#73)
…stal Code During Sidekick Order Hydration (#75) * Remove requirement on region name and identifier (CHK-6954) * Remove post code requirement from Sidekick hydration (CHK-6954) - Not all countries have postal codes, so this should not be a requirement.
…n Express Pay on Cart Page (#77) Fixes a "403 Forbidden" error thrown when calling the `saveShipping` AJAX endpoint while initializing PayPal in Express Pay on the cart page.
…duct Detail Page (#78)
…s on Product Detail Page (#80) * Create PDP flow in Checkout after config save (CHK-6711) * Set different Bold Checkout flow ID on product page (CHK-6711)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See PR #61, #62 and #65
Resolves CHK-4315