Fix when first item is nullable.

Closes #2
bombsimon · Oct 11, 2023 · 7ccca52 · 7ccca52
1 parent 3b0c904
commit 7ccca52
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/inferred_schema.go b/inferred_schema.go
@@ -75,7 +75,7 @@ func (i *InferredSchema) Infer(value any, hints Hints) *InferredSchema {
 	if i.SchemaType == SchemaTypeNullable {
 		return &InferredSchema{
 			SchemaType: SchemaTypeNullable,
-			Nullable:   i,
+			Nullable:   i.Nullable.Infer(value, hints),
 		}
 	}
 
@@ -258,7 +258,6 @@ func (i *InferredSchema) Infer(value any, hints Hints) *InferredSchema {
 			if subInfer, ok := i.Properties.Required[k]; ok {
 				i.Properties.Required[k] = subInfer.Infer(v, hints.SubHints(k))
 			} else if subInfer, ok := i.Properties.Optional[k]; ok {
-				i.Properties.Optional = ensureMap(i.Properties.Optional)
 				i.Properties.Optional[k] = subInfer.Infer(v, hints.SubHints(k))
 			} else {
 				i.Properties.Optional = ensureMap(i.Properties.Optional)

diff --git a/inferrer_test.go b/inferrer_test.go
@@ -43,6 +43,18 @@ func TestInferString(t *testing.T) {
 				},
 			},
 		},
+		{
+			description: "object first is null",
+			values:      []string{`{"name":null}`, `{"name":"Joe"}`},
+			expectedSchema: Schema{
+				Properties: map[string]Schema{
+					"name": {
+						Type:     jtd.TypeString,
+						Nullable: true,
+					},
+				},
+			},
+		},
 		{
 			description: "array",
 			values:      []string{`[1, 2, 3]`},